Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checks): Sort columns.onset numerically #1871

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

effigies
Copy link
Collaborator

Type coercion should not be assumed for TSV columns, as it may not be efficient. Therefore we should add a sorting method to determine whether something should be sorted lexically, numerically, or type-dependently (default).

This is implemented in the BIDS validator: bids-standard/bids-validator#2022

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (1418ce8) to head (63f8d8f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1871   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          16       16           
  Lines        1380     1380           
=======================================
  Hits         1215     1215           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies requested a review from rwblair July 18, 2024 21:15
@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Jul 18, 2024
@effigies effigies merged commit 3a636a1 into bids-standard:master Jul 18, 2024
28 checks passed
@effigies effigies deleted the schema/sort-methods branch July 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants