Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(schema): Drop context.dataset.files #1883

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Aug 5, 2024

While working on the validator, I realized context.dataset.files was never being populated, and didn't need to be. Removing the couple of uses from the rules and then removing context.dataset.files altogether.

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. schema-structure Changes to the fundamental organization/structure of the YAML schema. Minor version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (d2557e3) to head (1dc3d00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files          16       16           
  Lines        1391     1391           
=======================================
  Hits         1225     1225           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 3892f8e into bids-standard:master Aug 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release. schema-structure Changes to the fundamental organization/structure of the YAML schema. Minor version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants