-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide mermaid diagram of relation between BIDS schema, specification and validators #626
base: main
Are you sure you want to change the base?
Conversation
…n and validators This is based of the mermaid diagrams in the blog post we have: https://bids-website.readthedocs.io/en/latest/blog/2024/11/13/bids-validator-2.html and the goal is to give a visual depiction of relations between the components mentioned on this page and elsewhere.
for more information, see https://pre-commit.ci
I would remove the legacy validator from that diagram. |
The preview on read the docs shows a mermaid syntax error. This does not mean there is a real syntax error but that's the kind of problem when I was trying to use some of the more advanced mermaid features with mkdocs. |
It's not rendering here: https://bids-website--626.org.readthedocs.build/en/626/standards/index.html |
|
FWIW: does render now. |
@candleindark -- would you be so kind to see if you could tame the drawing so it is of better fidelity without zooming? Meanwhile, I have added here use of panzoom plugin (https://playg0n.github.io/mkdocs-panzoom/) which should enable zoom'ing "Mermaid and D2 are included by default". Seems to work nicely. |
I think the problem stems having too many items in the graph rather the arrangement of the items in the graph, but I will make an attempt. It would be nice if there is some mermaid support that allows zooming in of a particular region of the diagram, like the behavior of the prezi app. I don't think this problem is particular to us though. Many linkml generated diagrams suffer the same problem in presentation (For example, https://concepts.datalad.org/s/temporal/unreleased/). |
I think if we can get any large mermaid diagram to display in full window as https://anvaka.github.io/panzoom/demo/index.html would be great. The example is a live demo of https://github.com/anvaka/panzoom which is the base for https://playg0n.github.io/mkdocs-panzoom/ |
@candleindark I already added zoom/dragging here -- check preview at https://bids-website--626.org.readthedocs.build/en/626/standards/index.html . Do you propose something instead/on top of it? |
In a way, yes. I do think the one I mentioned is more better, but it is not a Mkdocs extension. I don't know if it's worth the time/effort to get it working. |
Nevermind, I just found out some a feature of the mkdocs extension you are using. I think it is good enough. |
@yarikoptic I was able to make the items in the diagram appear a bit larger and sent a PR to your branch. |
This adjustment will allow items in the mermaid diagram to appear bigger in the webpage because the page is more limited in the horizontal dimension. Additionally, the syntax of the mermaid diagram has been updated to the latest syntax, e.g. `flowchart` instead of `graph`. The intents of the lines in the diagram are those recommended/defaulted by the mermaid live editor at https://www.mermaidchart.com
999d39e
to
0d2e9b2
Compare
This is based of the mermaid diagrams in the blog post we have: https://bids-website.readthedocs.io/en/latest/blog/2024/11/13/bids-validator-2.html and the goal is to give a visual depiction of relations between the components mentioned on this page and elsewhere.
Here is a screenshot of preview. I do agree that text is a bit small'ish, so we might want to prune it but it is quite usable and IMHO useful... May be there is a way to make it "full screen"?
version1: horizontal, harder to read, no zooming etc
version2: vertical
version3: removed bids-apps and stats-models: