Minor refinements about software and cvterms #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following modelling:
@lazear in https://github.com/lazear/mz_parquet captures the CVterms for each spectrum, as Cvterm Accession and name. This approach is good but for data science I don't see people querying by CVTerms. I would love to extend that approach and use the following:
name: Name in the ontology (required). This will enable us to search in the ontologies easily.
value: Some of the ontology terms, for example, MS level, need a value, you can use MS level 2, Then this is optional because in the majority of the cases will be
null
.Capture the software provider at the project level.
Some minor changes to the schema double -> float32