Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of quantms v1.3.0 #405

Merged
merged 381 commits into from
Aug 29, 2024
Merged

Release of quantms v1.3.0 #405

merged 381 commits into from
Aug 29, 2024

Conversation

ypriverol
Copy link
Member

@ypriverol ypriverol commented Aug 15, 2024

This is the first release that will happen in bigbio, since we were archived in nf-core. We have to review all the code to spot small issues in the code, and the guidelines. Some things to pay attention:

  • Version, we have to make sure that the version we release is 1.3.0
  • Documentation, we have to make sure that the documentation in https://docs.quantms.org/en/latest/ and in docs/usage.md are updated
  • We have to make sure that the changelog is well-written because in the current version, we included new tools, new workflows and a lot of bug fixes.

Please @jpfeuffer @daichengxin @wfondrie @timosachsenberg if you can review the PR it would be great.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ypriverol
Copy link
Member Author

Are ready to release @daichengxin @jpfeuffer

@ypriverol ypriverol requested a review from jspaezp August 28, 2024 18:29
Copy link
Contributor

@wfondrie wfondrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous work folks. This looks good to me 🎉

@ypriverol ypriverol removed the request for review from timosachsenberg August 28, 2024 20:25
@ypriverol ypriverol merged commit 48622b8 into master Aug 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants