-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of quantms v1.3.0 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add the parameter of charge to SAGE processor and other properties
sdrf-pipelines 0.0.25 -> 0.0.26
Dev PR for Release 1.3
1.3.0dev -> 1.3.0
minor changes
update dependecies
jpfeuffer
reviewed
Aug 26, 2024
Are ready to release @daichengxin @jpfeuffer |
daichengxin
approved these changes
Aug 27, 2024
jspaezp
reviewed
Aug 27, 2024
jspaezp
reviewed
Aug 28, 2024
jspaezp
reviewed
Aug 28, 2024
jspaezp
reviewed
Aug 28, 2024
minor updating doc
Remove tests that depend on nf-core TOKENS
wfondrie
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendous work folks. This looks good to me 🎉
jspaezp
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first release that will happen in bigbio, since we were archived in nf-core. We have to review all the code to spot small issues in the code, and the guidelines. Some things to pay attention:
Please @jpfeuffer @daichengxin @wfondrie @timosachsenberg if you can review the PR it would be great.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).