Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to openms 3.2.0 #423
update to openms 3.2.0 #423
Changes from 50 commits
f8fa8e3
0c0c811
195beaa
9e42ec8
95b1cff
1b373be
912a545
a426e07
b03e080
19450e3
c78f16c
86c352c
9373df5
5e685df
7734f96
7d81745
a8f1d69
6935c24
7031000
8fc5f08
a078398
76cd7f0
bf6a143
f1210fc
9cb718d
10fa349
b17b33c
7e9cd11
c5005f1
e0ede9e
db3c7f7
1e5794f
dbf7cd5
d1d8820
6f87597
b1c433e
2f08ab4
d304266
6401b09
f0dbbe3
695d434
4c2b3e1
b13a7cb
8cab24a
a63cc85
fe9c4f7
dc766ed
f3c93ff
2586acc
1dc3e6d
87e2129
9d47118
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the log filename? This just confused everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is the plugin that we use to run the pipeline. I think it deletes or do something with the
.nextflow.log
. In a previous run I checked all the files created in the run and they were not.nextflow.log
, check this https://github.com/bigbio/quantms/actions/runs/11211083164/job/31159229622There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But who added this line? And why? It is not needed and broke the additional CI log uploads that I implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course there is no .nextflow.log anymore if you overwrite the default here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before writing the -log option it was not there. Check my CI/CD before adding the
-log
. I did try tols
all the files but the .nextflow.log was not there already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which plugin do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry misunderstood. I don't know why
.nextflow.log
is not there. I did thels -R -a
, but the file is not there, my point is that in other nf-core pipelines, it is not there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it is not there in other pipelines. They just don't try to upload it.
They are clearly saying it exists in the docs:
https://nf-co.re/docs/usage/troubleshooting/basics#categorize-the-type-of-error