🎨 applymap depreceated since pandas 2.1

[enryH]

User description

switch between applymap and map seems unnecessary using later versions of pandas.

---

PR Type

Bug fix, Enhancement

---

Description

• Replaced deprecated applymap with map for pandas compatibility.

• Removed conditional logic for Python version checks.

• Simplified validation logic for SDRF dataframes.

---

Changes walkthrough 📝

	Relevant files
Bug fix	sdrf_schema.py Updated SDRF validation to use `map` instead of `applymap` sdrf_pipelines/sdrf/sdrf_schema.py Replaced applymap with map for pandas compatibility. Removed Python version checks for conditional logic. Simplified the validation logic for empty cells. +6/-6

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Summary by CodeRabbit

• Refactor
  • Simplified validation method for DataFrame processing across different Python versions
  • Removed version-specific conditional logic in validation implementation

[coderabbitai]

Walkthrough

The changes involve simplifying the validate_empty_cells method in the SDRFSchema class by removing Python version-specific conditional logic. The method now uses the map method unconditionally across all Python versions, eliminating the previous differentiation between Python 3.8 and above versions for DataFrame validation.

Changes

File	Change Summary
sdrf_pipelines/sdrf/sdrf_schema.py	Removed version-specific conditional logic in validate_empty_cells method, now using map method universally

Poem

🐰 A Rabbit's Ode to Code Simplification 🥕

Version checks, once a tricky dance,
Now streamlined with a single glance
Map method reigns, no version fear
Cleaner code, the path is clear!
Hop, hop, simplicity is near!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7af4ccf and b0e5648.

📒 Files selected for processing (1)

• sdrf_pipelines/sdrf/sdrf_schema.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• sdrf_pipelines/sdrf/sdrf_schema.py

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Commented Code The PR leaves commented out code that should be removed since it's no longer needed after the migration to using map() only. # if sys.version_info <= (3, 8): # # Use map for Python versions less than 3.8 validation_results = panda_sdrf.map(validate_string) # else: # # Use applymap for Python versions 3.8 and above # validation_results = panda_sdrf.applymap(validate_string)

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	✅ Remove commented-out code to improve code clarity and maintainability Suggestion Impact: The commit removed the commented-out code blocks that were checking Python version to decide between map and applymap usage code diff: - # if sys.version_info <= (3, 8): - # # Use map for Python versions less than 3.8 validation_results = panda_sdrf.map(validate_string) - # else: - # # Use applymap for Python versions 3.8 and above - # validation_results = panda_sdrf.applymap(validate_string) Remove the commented-out code since it's no longer needed and can cause confusion. The code now correctly uses map which is the recommended approach in pandas 2.1+. sdrf_pipelines/sdrf/sdrf_schema.py [364-369] -# if sys.version_info <= (3, 8): -# # Use map for Python versions less than 3.8 validation_results = panda_sdrf.map(validate_string) -# else: -# # Use applymap for Python versions 3.8 and above -# validation_results = panda_sdrf.applymap(validate_string) Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies redundant commented-out code that should be removed since the PR has already made the decision to use map() consistently. Removing dead code improves readability and prevents confusion about which code path is actually being used.	7

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

sdrf_pipelines/sdrf/sdrf_schema.py (1)

364-369: LGTM! Consider removing the commented code.

The change to use map unconditionally is correct as it aligns with pandas' deprecation of applymap since version 2.1.0. However, since the version-specific code is no longer needed, consider removing the commented code for cleaner maintenance.

-        # if sys.version_info <= (3, 8):
-        #     # Use map for Python versions less than 3.8
-        #     validation_results = panda_sdrf.map(validate_string)
-        # else:
-        #     # Use applymap for Python versions 3.8 and above
-        #     validation_results = panda_sdrf.applymap(validate_string)
+        validation_results = panda_sdrf.map(validate_string)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f09b231 and 7af4ccf.

📒 Files selected for processing (1)

• sdrf_pipelines/sdrf/sdrf_schema.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

[enryH]

I haven't run the test locally and would see what the GitHub Actions say...