Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix problem when new user comes in, modal pops up #25

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Nov 7, 2024

What does this PR do?

Fixed issue when new user comes into the meeting, a modal showing the picked random user pops out to them.

New behaviour (following other features in BBB where the UI of the viewer should look like the presenter's):

  • The presenter picks a random user;
  • If the presenter still viewing the picked user, any new student that comes in, modal will pop out, so they see the same as the presenter (mind that there is the possibility for this user to close the modal);
  • If the presenter has picked the user, but simply followed along with the class and now there is no modal to the presenter, any new student that comes in will not see the modal popping in.

Those are the premises I used for building this up, comment down below any suggestions you might have and let's discuss.

Closes Issue(s)

Closes #10

More

See a demo of the last case scenario mentioned here in this PR (presenter closed the modal already):

fix-pick-random-user-new-user-modal-popingout.mp4

@GuiLeme GuiLeme requested a review from lfzawacki November 8, 2024 12:01
@antobinary antobinary merged commit 3362d98 into bigbluebutton:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New users in a meeting will always see the plugin modal
3 participants