Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5646 [update] Checkouts, changes to discounts #186

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

bc-traciporter
Copy link
Collaborator

@bc-traciporter bc-traciporter commented Mar 21, 2024

DEVDOCS-5646

What changed?

Updated checkout discount endpoint

Release notes draft

V3/Discounts API can now be used to add item-level discount in addition to cart level discount

Anything else?

Initial PR: PR 1517
Checkout-7756

ping @valentindellangela and @bc-charlesho for review

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Mar 21, 2024
Copy link
Contributor

@valentindellangela valentindellangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@valentindellangela
Copy link
Contributor

@bc-charlesho Perhaps I can turn on the feature flag on Monday so when we release the dev doc, it's available?

@bc-charlesho
Copy link

@bc-traciporter can we commence this rollout next Monday Sydney time? When would you like us to roll out so that it is in sync with the publishing of the the dev docs?

@bc-traciporter
Copy link
Collaborator Author

@bc-traciporter can we commence this rollout next Monday Sydney time? When would you like us to roll out so that it is in sync with the publishing of the the dev docs?

@bc-charlesho I can merge the PR Monday at 4 pm CST. Would that work or would you need a later time?

Copy link
Collaborator

@bc-tgomez bc-tgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one edit and a few comments. Not sure how you feel about *item-level since we use cart-level? Up to you! I'll approve right after.

reference/checkouts.v3.yml Outdated Show resolved Hide resolved
reference/checkouts.v3.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@bc-tgomez bc-tgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@bc-traciporter bc-traciporter added awaiting-css-cue and removed ready for review This PR is complete and awaiting a review. labels Mar 22, 2024
@slsriehl slsriehl changed the title DEVDOCS-5646 [update] updated changes to discounts DEVDOCS-5646 [update] Checkouts, changes to discounts Mar 25, 2024
@bc-traciporter bc-traciporter merged commit 0c124d0 into main Mar 25, 2024
4 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-5646-discounts branch March 25, 2024 17:50
bc-tgomez added a commit that referenced this pull request Apr 26, 2024
<!-- Ticket number or summary of work -->
# [DEVDOCS-5646]


## What changed?
Updated checkout discount endpoint

## Release notes draft
V3/Discounts API can now be used to add item-level discount in addition
to cart level discount


## Anything else?
Initial PR: [PR
1517](bigcommerce/api-specs#1517)

[Checkout-7756](https://bigcommercecloud.atlassian.net/browse/CHECKOUT-7756)


ping @valentindellangela and @bc-charlesho for review


[DEVDOCS-5646]:
https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5646?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Tina Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants