-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVDOCS-5646 [update] Checkouts, changes to discounts #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
@bc-charlesho Perhaps I can turn on the feature flag on Monday so when we release the dev doc, it's available? |
@bc-traciporter can we commence this rollout next Monday Sydney time? When would you like us to roll out so that it is in sync with the publishing of the the dev docs? |
@bc-charlesho I can merge the PR Monday at 4 pm CST. Would that work or would you need a later time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one edit and a few comments. Not sure how you feel about *item-level since we use cart-level? Up to you! I'll approve right after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
<!-- Ticket number or summary of work --> # [DEVDOCS-5646] ## What changed? Updated checkout discount endpoint ## Release notes draft V3/Discounts API can now be used to add item-level discount in addition to cart level discount ## Anything else? Initial PR: [PR 1517](bigcommerce/api-specs#1517) [Checkout-7756](https://bigcommercecloud.atlassian.net/browse/CHECKOUT-7756) ping @valentindellangela and @bc-charlesho for review [DEVDOCS-5646]: https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5646?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Tina Gomez <[email protected]>
DEVDOCS-5646
What changed?
Updated checkout discount endpoint
Release notes draft
V3/Discounts API can now be used to add item-level discount in addition to cart level discount
Anything else?
Initial PR: PR 1517
Checkout-7756
ping @valentindellangela and @bc-charlesho for review