Feature: add extensionsToIgnore to withExtensions #3195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extensionsToIgnore
has been added towithExtensions
which allows developers to filter the extensions within the internal api.Corresponding issue:
bigskysoftware/htmx-extensions#145
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
I've manually tested it by creating an extension
merge-vals
that modifies the parameters throughencodeParameters
, while being used at the same time withjson-enc-custom
like sothe extension implementation:
The issue with this implementation is that htmx will only use the first extension that modifies the parameters, so
json-custom-enc
will never be useda simple fix would to manually call the extensions like so
Now, a different issue arises,
withExtensions
will get all the specified extensions from the element, includingmerge-vals
which will cause an infinity loopThis PR introduces
extensionsToIgnore
intowithExntensions
which fixes this issue without the introduction of a breaking change to the logic of encode parametersChecklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded