fix: menu links for details page and tests

bihealth · Oct 18, 2023 · 8b21a51 · 8b21a51
1 parent a604845
commit 8b21a51
Show file tree

Hide file tree

Showing 12 changed files with 47 additions and 51 deletions.
diff --git a/frontend/src/components/HeaderDefault.vue b/frontend/src/components/HeaderDefault.vue
@@ -20,22 +20,22 @@ import UserProfileButton from '@/components/UserProfileButton.vue'
     <v-spacer></v-spacer>
     <v-toolbar-items class="topbar-links">
       <UserProfileButton />
-      <v-menu>
+      <v-menu id="menu">
         <template v-slot:activator="{ props }">
           <v-btn icon="mdi-dots-vertical" v-bind="props"></v-btn>
         </template>
 
         <v-list>
-          <v-list-item to="/about">
+          <v-list-item to="/about" id="about">
             <v-list-item-title> About </v-list-item-title>
           </v-list-item>
-          <v-list-item to="/contact">
+          <v-list-item to="/contact" id="contact">
             <v-list-item-title> Contact </v-list-item-title>
           </v-list-item>
-          <v-list-item to="/privacy">
+          <v-list-item to="/privacy" id="privacy">
             <v-list-item-title> Privacy Policy </v-list-item-title>
           </v-list-item>
-          <v-list-item to="/terms">
+          <v-list-item to="/terms" id="terms">
             <v-list-item-title> Terms of Use </v-list-item-title>
           </v-list-item>
         </v-list>

diff --git a/frontend/src/components/HeaderDetailPage.vue b/frontend/src/components/HeaderDetailPage.vue
@@ -64,9 +64,27 @@ watch(() => props.searchTerm, updateTerms)
     />
     <v-spacer></v-spacer>
     <v-toolbar-items class="topbar-links">
-      <v-btn id="about" to="/about"> About </v-btn>
-      <v-btn id="contact" to="/contact"> Contact </v-btn>
       <UserProfileButton />
+      <v-menu id="menu">
+        <template v-slot:activator="{ props }">
+          <v-btn icon="mdi-dots-vertical" v-bind="props"></v-btn>
+        </template>
+
+        <v-list>
+          <v-list-item to="/about" id="about">
+            <v-list-item-title> About </v-list-item-title>
+          </v-list-item>
+          <v-list-item to="/contact" id="contact">
+            <v-list-item-title> Contact </v-list-item-title>
+          </v-list-item>
+          <v-list-item to="/privacy" id="privacy">
+            <v-list-item-title> Privacy Policy </v-list-item-title>
+          </v-list-item>
+          <v-list-item to="/terms" id="terms">
+            <v-list-item-title> Terms of Use </v-list-item-title>
+          </v-list-item>
+        </v-list>
+      </v-menu>
     </v-toolbar-items>
   </v-app-bar>
 </template>

diff --git a/frontend/src/components/__tests__/HeaderDefault.spec.ts b/frontend/src/components/__tests__/HeaderDefault.spec.ts
@@ -35,9 +35,7 @@ describe.concurrent('HeaderDefault.vue', () => {
       }
     )
 
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    const menu = wrapper.find('#menu')
+    expect(menu.exists()).toBe(true)
   })
 })
diff --git a/frontend/src/components/__tests__/HeaderDetailPage.spec.ts b/frontend/src/components/__tests__/HeaderDetailPage.spec.ts
@@ -40,11 +40,9 @@ describe.concurrent('HeaderDetailPage', async () => {
     store.geneInfo = JSON.parse(JSON.stringify(geneData.geneInfo))
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the search bar', async () => {

diff --git a/frontend/src/views/__tests__/ACMGCriteriaDoc.spec.ts b/frontend/src/views/__tests__/ACMGCriteriaDoc.spec.ts
@@ -18,11 +18,9 @@ describe.concurrent('ACMGCriteriaDocs', async () => {
     )
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the main content', () => {

diff --git a/frontend/src/views/__tests__/ACMGSVDocs.spec.ts b/frontend/src/views/__tests__/ACMGSVDocs.spec.ts
@@ -18,11 +18,9 @@ describe.concurrent('ACMGSVDocs', async () => {
     )
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the main content', () => {

diff --git a/frontend/src/views/__tests__/AboutView.spec.ts b/frontend/src/views/__tests__/AboutView.spec.ts
@@ -18,11 +18,9 @@ describe.concurrent('AboutView', async () => {
     )
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the main content', () => {

diff --git a/frontend/src/views/__tests__/ContactView.spec.ts b/frontend/src/views/__tests__/ContactView.spec.ts
@@ -18,11 +18,9 @@ describe.concurrent('ContactView', async () => {
     )
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the main content', () => {

diff --git a/frontend/src/views/__tests__/GeneDetailView.spec.ts b/frontend/src/views/__tests__/GeneDetailView.spec.ts
@@ -55,11 +55,9 @@ describe.concurrent('GeneDetailView', async () => {
     expect(searchBar.exists()).toBe(true)
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
 
     const launchImage = wrapper.findAll('.mdi-launch')
     expect(launchImage.length).toBe(14)
@@ -74,11 +72,9 @@ describe.concurrent('GeneDetailView', async () => {
     expect(searchBar.exists()).toBe(true)
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders info-cards and navigation drawer', () => {

diff --git a/frontend/src/views/__tests__/GenesListView.spec.ts b/frontend/src/views/__tests__/GenesListView.spec.ts
@@ -68,11 +68,9 @@ describe.concurrent('GenesListView', async () => {
     expect(searchBar.exists()).toBe(true)
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the search results', async () => {

diff --git a/frontend/src/views/__tests__/HomeView.spec.ts b/frontend/src/views/__tests__/HomeView.spec.ts
@@ -50,11 +50,9 @@ describe.concurrent('HomeView with mocked router', async () => {
     expect(footer.exists()).toBe(true)
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('renders the search bar', () => {

diff --git a/frontend/src/views/__tests__/VariantDetailView.spec.ts b/frontend/src/views/__tests__/VariantDetailView.spec.ts
@@ -105,11 +105,9 @@ describe('VariantDetailView', async () => {
     expect(searchBar.exists()).toBe(true)
 
     const logo = wrapper.find('#logo')
-    const aboutLink = wrapper.find('#about')
-    const contactLink = wrapper.find('#contact')
+    const menu = wrapper.find('#menu')
     expect(logo.exists()).toBe(true)
-    expect(aboutLink.exists()).toBe(true)
-    expect(contactLink.exists()).toBe(true)
+    expect(menu.exists()).toBe(true)
   })
 
   it('emits update in header', async () => {