-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implementation of reverse proxies for varfish-docker-compose-ng
(#10)
#12
feat: Implementation of reverse proxies for varfish-docker-compose-ng
(#10)
#12
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
============================================
+ Coverage 10.52% 100.00% +89.47%
============================================
Files 2 3 +1
Lines 19 41 +22
============================================
+ Hits 2 41 +39
+ Misses 17 0 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge after doing the requested fixes and verifying that python backend coverage is 100% afterwards
backend/Pipfile
Outdated
@@ -7,17 +7,22 @@ name = "pypi" | |||
fastapi = "*" | |||
pydantic = "*" | |||
uvicorn = "*" | |||
python-dotenv = "*" | |||
httpx = "*" | |||
pytest-asyncio = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest-asyncio should be moved to dev-packages
backend/app/main.py
Outdated
|
||
#: pragma: no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this behind the following line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can verify the result here https://app.codecov.io/gh/bihealth/reev/pull/12/blob/backend/app/main.py
Issue #10
Subtasks: