Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow users to bookmark variants and genes (#95) #173

Merged
merged 10 commits into from
Oct 27, 2023
Merged

feat: Allow users to bookmark variants and genes (#95) #173

merged 10 commits into from
Oct 27, 2023

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Oct 23, 2023 •
edited
Loading

TODO:

  • Add models, schemas and api in backend
  • Add tests
  • Add frontend bookmarks behaviour
  • Add frontend bookmark page in profile section
  • Test

@gromdimon gromdimon linked an issue Oct 23, 2023 that may be closed by this pull request
Allow users to bookmark variants and genes #95
Closed
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #173 (fa28906) into main (a7e2853) will decrease coverage by 0.80%.
The diff coverage is 75.78%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   79.72%   78.92%   -0.80%     
==========================================
  Files         103       75      -28     
  Lines        2934     2548     -386     
  Branches      762      775      +13     
==========================================
- Hits         2339     2011     -328     
+ Misses        553      492      -61     
- Partials       42       45       +3
Files Coverage Δ
frontend/src/api/bookmarks.ts 100.00% <100.00%> (ø)
frontend/src/views/GeneDetailView.vue 92.30% <ø> (ø)
frontend/src/views/SvDetailView.vue 0.00% <ø> (ø)
frontend/src/views/VariantDetailView.vue 77.55% <ø> (ø)
frontend/src/stores/bookmarks.ts 86.66% <86.66%> (ø)
frontend/src/views/ProfileView.vue 71.42% <64.70%> (-8.58%) ⬇️
frontend/src/components/BookmarkButton.vue 55.17% <55.17%> (ø)

... and 31 files with indirect coverage changes

@gromdimon gromdimon self-assigned this Oct 25, 2023
holtgrewe
holtgrewe previously requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks sane except for some discrepancies in the frontend.

backend/alembic/versions/435a8e31682e_init_bookmarks.py Outdated Show resolved Hide resolved
backend/alembic/versions/435a8e31682e_init_bookmarks.py Outdated Show resolved Hide resolved
backend/app/api/api_v1/endpoints/bookmarks.py Outdated Show resolved Hide resolved
backend/app/crud/bookmarks.py Outdated Show resolved Hide resolved
backend/app/crud/bookmarks.py Outdated Show resolved Hide resolved
frontend/src/api/bookmarks.ts Outdated Show resolved Hide resolved
frontend/src/api/bookmarks.ts Outdated Show resolved Hide resolved
frontend/src/components/BookmarkButton.vue Outdated Show resolved Hide resolved
frontend/src/components/BookmarkButton.vue Outdated Show resolved Hide resolved
frontend/src/views/ProfileView.vue Outdated Show resolved Hide resolved
@gromdimon gromdimon enabled auto-merge (squash) October 27, 2023 16:43
@gromdimon gromdimon dismissed holtgrewe’s stale review October 27, 2023 16:49

All the requests were met.

@gromdimon gromdimon merged commit 162ae13 into main Oct 27, 2023
9 of 10 checks passed
@gromdimon gromdimon deleted the 95-allow-users-to-bookmark branch October 27, 2023 16:49
@varfish-bot varfish-bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe left review comments

Assignees

@gromdimon gromdimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to bookmark variants and genes
2 participants
@gromdimon @holtgrewe