Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow user to store case information with their account (#94, #179) #178

Merged

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Oct 30, 2023

Tasks:

  • Implement backend model, schema, api's
  • Add backend tests
  • Add frontend calls
  • Fix small issues

@gromdimon gromdimon linked an issue Oct 30, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #178 (e4be305) into main (247d9b1) will decrease coverage by 1.40%.
The diff coverage is 66.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   79.55%   78.16%   -1.40%     
==========================================
  Files         112      119       +7     
  Lines        3179     3512     +333     
  Branches      793      817      +24     
==========================================
+ Hits         2529     2745     +216     
- Misses        603      711     +108     
- Partials       47       56       +9     
Files Coverage Δ
backend/app/api/api_v1/api.py 52.38% <100.00%> (+1.16%) ⬆️
backend/app/api/api_v1/endpoints/bookmarks.py 62.16% <ø> (ø)
backend/app/crud/__init__.py 100.00% <100.00%> (ø)
backend/app/crud/bookmarks.py 100.00% <ø> (ø)
backend/app/models/__init__.py 100.00% <100.00%> (ø)
backend/app/models/caseinfo.py 100.00% <100.00%> (ø)
backend/app/schemas/__init__.py 100.00% <100.00%> (ø)
backend/app/schemas/caseinfo.py 100.00% <100.00%> (ø)
frontend/src/api/caseinfo.ts 100.00% <100.00%> (ø)
frontend/src/api/common.ts 100.00% <100.00%> (ø)
... and 12 more

Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to judge the view code by itself.

The backend looks sane except for the mismatch of the Alembic and Python enums.

Also, in principle users can have more than one caseinfo. Which case info is loaded in the UI?

backend/alembic/versions/c287a4866a9a_init_caseinfo.py Outdated Show resolved Hide resolved
@gromdimon gromdimon linked an issue Nov 1, 2023 that may be closed by this pull request
@gromdimon gromdimon marked this pull request as draft November 1, 2023 11:27
@gromdimon gromdimon self-assigned this Nov 3, 2023
@gromdimon gromdimon changed the title feat: Allow user to store case information with their account (#94) feat: Allow user to store case information with their account (#94, #179) Nov 3, 2023
@gromdimon gromdimon marked this pull request as ready for review November 6, 2023 09:31
@gromdimon gromdimon merged commit 3301d74 into main Nov 6, 2023
8 of 9 checks passed
@gromdimon gromdimon deleted the 94-allow-user-to-store-case-information-with-their-account branch November 6, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement search for diseases and HPO terms Allow user to store case information with their account
2 participants