Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to save acmg criteria on the server (#98) #237

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Nov 29, 2023

Tasks:

  • Create schemas, models, apis
  • Add tests
  • Frontend adaptation

@gromdimon gromdimon linked an issue Nov 29, 2023 that may be closed by this pull request
@gromdimon gromdimon self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #237 (e76cb57) into main (d3df9d7) will decrease coverage by 4.05%.
Report is 2 commits behind head on main.
The diff coverage is 77.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   80.12%   76.08%   -4.05%     
==========================================
  Files         133      145      +12     
  Lines        4172     4684     +512     
  Branches      973     1080     +107     
==========================================
+ Hits         3343     3564     +221     
- Misses        758      996     +238     
- Partials       71      124      +53     
Files Coverage Δ
backend/app/api/api_v1/api.py 53.19% <100.00%> (+1.01%) ⬆️
backend/app/crud/__init__.py 100.00% <100.00%> (ø)
backend/app/crud/acmgseqvar.py 100.00% <100.00%> (ø)
backend/app/models/__init__.py 100.00% <100.00%> (ø)
backend/app/models/acmgseqvar.py 100.00% <100.00%> (ø)
backend/app/schemas/__init__.py 100.00% <100.00%> (ø)
backend/app/schemas/acmgseqvar.py 100.00% <100.00%> (ø)
frontend/src/api/acmgseqvar.ts 100.00% <100.00%> (ø)
frontend/src/lib/acmgSeqVar.ts 97.75% <100.00%> (+0.06%) ⬆️
backend/app/api/api_v1/endpoints/caseinfo.py 73.46% <83.33%> (ø)
... and 3 more

... and 30 files with indirect coverage changes

@gromdimon gromdimon marked this pull request as draft November 29, 2023 10:49
@gromdimon gromdimon marked this pull request as ready for review December 1, 2023 12:39
@gromdimon gromdimon merged commit 8738ca4 into main Dec 1, 2023
8 of 9 checks passed
@gromdimon gromdimon deleted the 98-allow-users-to-save-acmg-criteria-on-the-server branch December 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to save ACMG criteria on the server
1 participant