Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: documenting ACMG criteria (#429) #440

Merged
merged 2 commits into from
Feb 6, 2024
Merged

docs: documenting ACMG criteria (#429) #440

merged 2 commits into from
Feb 6, 2024

Conversation

holtgrewe
Copy link
Member

@holtgrewe holtgrewe commented Feb 6, 2024 •
edited by xiamaz
Loading

Closes #429

@holtgrewe holtgrewe added this to the 0.6.0 milestone Feb 6, 2024
@holtgrewe holtgrewe requested a review from xiamaz February 6, 2024 09:35
@holtgrewe holtgrewe marked this pull request as draft February 6, 2024 09:37
@holtgrewe holtgrewe mentioned this pull request Feb 6, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (715f05c) 73.22% compared to head (4e4a356) 73.22%.
Report is 7 commits behind head on main.

❗ Current head 4e4a356 differs from pull request most recent head f1c9320. Consider uploading reports for the commit f1c9320 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          97       97           
  Lines        3843     3843           
  Branches      682      682           
=======================================
  Hits         2814     2814           
  Misses        882      882           
  Partials      147      147

xiamaz
xiamaz approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiamaz xiamaz marked this pull request as ready for review February 6, 2024 20:16
@xiamaz xiamaz enabled auto-merge (squash) February 6, 2024 20:17
@xiamaz xiamaz merged commit 62bfd70 into main Feb 6, 2024
8 checks passed
@xiamaz xiamaz deleted the 429-docs-acmg-criteria branch February 6, 2024 20:19
@xiamaz xiamaz mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiamaz xiamaz xiamaz approved these changes

Assignees

@xiamaz xiamaz

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Document criteria filled out by InterVar and AutoCNV
2 participants
@holtgrewe @xiamaz