Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CaseInfo loading/saving/updating functionality (#501) #507

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

gromdimon
Copy link
Contributor

No description provided.

@gromdimon gromdimon linked an issue Feb 12, 2024 that may be closed by this pull request
@gromdimon gromdimon changed the title fix: Proper CaseInfo usage (#501) fix: CaseInfo loading/saving/updating functionality (#501) Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b7d34af) 73.21% compared to head (9a8b279) 73.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   73.21%   73.13%   -0.08%     
==========================================
  Files          98       98              
  Lines        3860     3871      +11     
  Branches      688      695       +7     
==========================================
+ Hits         2826     2831       +5     
- Misses        886      889       +3     
- Partials      148      151       +3     
Files Coverage Δ
backend/app/api/api_v1/endpoints/caseinfo.py 100.00% <100.00%> (ø)
backend/app/schemas/caseinfo.py 100.00% <100.00%> (ø)
frontend/src/stores/caseInfo/constants.ts 100.00% <ø> (ø)
frontend/src/stores/caseInfo/types.ts 100.00% <ø> (ø)
frontend/src/stores/caseInfo/store.ts 83.33% <45.45%> (-4.72%) ⬇️

@gromdimon
Copy link
Contributor Author

gromdimon commented Feb 12, 2024

TODO:

  • Unificate CaseInfo related types
  • Review local / server variants of CaseInfo
  • Add migration for enums: omim_id -> omimId and term_id -> termId

@gromdimon gromdimon marked this pull request as ready for review February 14, 2024 12:48
@gromdimon gromdimon merged commit ad264c2 into main Feb 14, 2024
8 of 9 checks passed
@gromdimon gromdimon deleted the 501-cada-prio-service-returns-500-errors branch February 14, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cada-prio service returns 500 errors
1 participant