simplify syncmodifyapi project querying (#1264)

CHANGELOG.rst

@@ -30,6 +30,7 @@ Changed
     - Move ``setup_ip_allowing()`` to ``IPAllowMixin`` (#1237)
     - Improve ``syncmodifyapi`` project logging (#1228)
     - Do not exit ``syncmodifyapi`` on failure (#1229)
+    - Simplify ``syncmodifyapi`` project querying (#1264)
 - **Timeline**
     - Handle app plugin exceptions in ``get_object_link()`` (#1232)
 

projectroles/management/commands/syncmodifyapi.py

@@ -25,19 +25,6 @@
 class Command(ProjectModifyPluginViewMixin, BaseCommand):
     help = 'Synchronizes existing projects using the project modify API'
 
-    def _get_projects(self, project, project_list):
-        """
-        Retrieve projects recursively in inheritance order.
-
-        :param project: Current project
-        :param project_list: List of Project objects
-        """
-        project_list.append(project)
-        logger.debug('Added: {}'.format(project.full_title))
-        for c in Project.objects.filter(parent=project):
-            self._get_projects(c, project_list)
-        return project_list
-
     def add_arguments(self, parser):
         parser.add_argument(
             '-p',
@@ -61,14 +48,9 @@ def handle(self, *args, **options):
             project_list = [project]
         else:
             logger.info('Synchronizing all projects..')
-            project_list = []
-            top_cats = Project.objects.filter(
-                type=PROJECT_TYPE_CATEGORY, parent=None
-            )
-            for c in top_cats:
-                self._get_projects(c, project_list)
+            project_list = Project.objects.all().order_by('full_title')
             logger.debug(
-                'Found {} projects and categories'.format(len(project_list))
+                'Found {} projects and categories'.format(project_list.count())
             )
         sync_count = 0
         err_count = 0