Skip to content

Commit

Permalink
remove redundant UserSettingRetrieveAPIView perm (#1449)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikkonie committed Jul 15, 2024
1 parent 99e4ef3 commit d61c5c9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ Removed
- ``user_email_additional`` app setting (#874)
- ``get_visible_projects()`` template tag (#1432)
- App setting value max length limit (#1443)
- Redundant project permission in ``UserSettingRetrieveAPIView`` (#1449)


v0.13.4 (2024-02-16)
Expand Down
2 changes: 0 additions & 2 deletions projectroles/views_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1237,8 +1237,6 @@ class UserSettingRetrieveAPIView(
- ``setting_name``: Setting name (string)
"""

# NOTE: Update project settings perm is checked manually
permission_required = 'projectroles.view_project'
schema = AutoSchema(operation_id_base='AppSettingUser')
serializer_class = AppSettingSerializer

Expand Down

0 comments on commit d61c5c9

Please sign in to comment.