update remote sync ui app setting rendering (#1473, #1474)

bihealth · Sep 2, 2024 · d91eede · d91eede
1 parent 7174f62
commit d91eede
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 10 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -8,11 +8,18 @@ Changelog for the **SODAR Core** Django app package. Loosely follows the
 Unreleased
 ==========
 
+Added
+-----
+
+- **Projectroles**
+    - Truncate app setting values in ``remoteproject_sync.html`` (#1474)
+
 Fixed
 -----
 
 - **Projectroles**
     - Incorrect app plugin link order in ``get_project_app_links()`` (#1468)
+    - Empty JSON value rendering in ``remoteproject_sync.html`` (#1473)
 
 
 v1.0.1 (2024-08-08)

diff --git a/docs/source/major_changes.rst b/docs/source/major_changes.rst
@@ -16,7 +16,9 @@ v1.0.2 (WIP)
 Release Highlights
 ==================
 
-TBA
+- Update app setting rendering in remote sync UI
+- Fix project sidebar and dropdown app plugin link order
+- General bug fixes and minor updates
 
 
 v1.0.1 (2024-08-08)

diff --git a/projectroles/templates/projectroles/remoteproject_sync.html b/projectroles/templates/projectroles/remoteproject_sync.html
@@ -252,15 +252,15 @@ <h4>
                     <td>
                       {% if a.app_plugin %}{{ a.app_plugin }}{% else %}projectroles{% endif %}
                     </td>
-                    <td>
-                      {% if a.type == 'JSON' %}
-                        {{ a.value_json }}
-                      {% elif a.type == 'BOOLEAN' %}
-                        {% if a.value == '1' %}True{% else %}False{% endif %}
-                      {% else %}
-                        {{ a.value }}
-                      {% endif %}
-                    </td>
+                    {% if a.type == 'JSON' and a.value_json %}
+                      <td class="text-muted font-italic">JSON</td>
+                    {% elif a.type == 'JSON' %}
+                      <td class="text-muted font-italic">Empty</td>
+                    {% elif a.type == 'BOOLEAN' %}
+                      <td class="text-monospace">{% if a.value == '1' %}True{% else %}False{% endif %}</td>
+                    {% else %}
+                      <td class="text-monospace">{{ a.value | truncatechars:255 }}</td>
+                    {% endif %}
                     <td>{{ a.status | title }}</td>
                   </tr>
                 {% endif %}