Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user dropdown logic into reusable component #1386

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Refactor user dropdown logic into reusable component #1386

merged 7 commits into from
Apr 11, 2024

Conversation

gromdimon
Copy link
Collaborator

Issue: #1381

@gromdimon gromdimon marked this pull request as ready for review March 6, 2024 17:25
@gromdimon gromdimon added this to the v1.0.0 milestone Mar 7, 2024
@gromdimon gromdimon self-assigned this Mar 7, 2024
@gromdimon gromdimon force-pushed the 1381-refactor-user-dropdown-logic-into-reusable-component branch from a94e444 to cb6b878 Compare March 19, 2024 19:11
@gromdimon gromdimon requested a review from mikkonie March 19, 2024 19:22
mikkonie
mikkonie requested changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I found one bug and have some requests for refactoring and minor cleanup.

projectroles/templates/projectroles/_site_titlebar_dropdown.html Outdated Show resolved Hide resolved
projectroles/templatetags/projectroles_tags.py Outdated Show resolved Hide resolved
projectroles/utils.py Show resolved Hide resolved
projectroles/utils.py Outdated Show resolved Hide resolved
projectroles/utils.py Outdated Show resolved Hide resolved
projectroles/tests/test_templatetags.py Outdated Show resolved Hide resolved
projectroles/tests/test_templatetags.py Show resolved Hide resolved
@gromdimon gromdimon force-pushed the 1381-refactor-user-dropdown-logic-into-reusable-component branch from 8b79d03 to 3abac2f Compare March 27, 2024 13:35
@gromdimon gromdimon requested a review from mikkonie March 27, 2024 14:03
@gromdimon gromdimon linked an issue Mar 27, 2024 that may be closed by this pull request
Refactor user dropdown logic into reusable component #1381
Closed
5 tasks
mikkonie
mikkonie requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work again, had just a few small comments. After fixing these I'm sure we can merge :)

projectroles/templatetags/projectroles_tags.py Outdated Show resolved Hide resolved
projectroles/tests/test_templatetags.py Outdated Show resolved Hide resolved
projectroles/tests/test_templatetags.py Outdated Show resolved Hide resolved
projectroles/tests/test_templatetags.py Outdated Show resolved Hide resolved
@gromdimon gromdimon force-pushed the 1381-refactor-user-dropdown-logic-into-reusable-component branch from a54e442 to f8de949 Compare April 10, 2024 13:25
@gromdimon gromdimon requested a review from mikkonie April 10, 2024 13:42
mikkonie
mikkonie approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking good, this can be merged.

@mikkonie mikkonie merged commit c68e351 into dev Apr 11, 2024
5 checks passed
@mikkonie mikkonie deleted the 1381-refactor-user-dropdown-logic-into-reusable-component branch April 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkonie mikkonie mikkonie approved these changes

Assignees

@gromdimon gromdimon

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Refactor user dropdown logic into reusable component
2 participants
@gromdimon @mikkonie