Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ajax views for retrieving sidebar and user dropdown links #1420

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Add ajax views for retrieving sidebar and user dropdown links #1420

merged 9 commits into from
Apr 29, 2024

Conversation

gromdimon
Copy link
Collaborator

Issue: #1366

@gromdimon gromdimon linked an issue Apr 25, 2024 that may be closed by this pull request
Add Ajax views for retrieving sidebar and user dropdown links #1366
Closed
4 tasks
@gromdimon gromdimon changed the base branch from main to dev April 25, 2024 10:15
@gromdimon gromdimon self-assigned this Apr 25, 2024
@gromdimon gromdimon marked this pull request as ready for review April 25, 2024 11:41
@gromdimon
Copy link
Collaborator Author

gromdimon commented Apr 25, 2024 •
edited
Loading

  • Added ajax views
  • Added urls
  • Added tests
  • Added docstrings for usage

@gromdimon gromdimon requested a review from mikkonie April 25, 2024 11:42
mikkonie
mikkonie requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I added some requests to remove the url_name parameters from Ajax views as they are not necessary.

projectroles/views_ajax.py Outdated Show resolved Hide resolved
projectroles/views_ajax.py Outdated Show resolved Hide resolved
mikkonie
mikkonie requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One more comment regarding permission tests for the ajax views. Once we have permission tests in place, I'll be happy to merge.

projectroles/tests/test_views_ajax.py Show resolved Hide resolved
mikkonie
mikkonie requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup comments, otherwise looking good.

projectroles/tests/test_permissions_ajax.py Outdated Show resolved Hide resolved
projectroles/tests/test_permissions_ajax.py Outdated Show resolved Hide resolved
projectroles/tests/test_permissions_ajax.py Outdated Show resolved Hide resolved
@mikkonie mikkonie merged commit 2a69170 into dev Apr 29, 2024
5 checks passed
@mikkonie mikkonie deleted the 1366-add-ajax-views-for-retrieving-sidebar-and-user-dropdown-links branch April 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkonie mikkonie mikkonie approved these changes

Assignees

@gromdimon gromdimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ajax views for retrieving sidebar and user dropdown links
2 participants
@gromdimon @mikkonie