Form proper labels for Category/Project update link

[gromdimon]

Issue: #1421

[mikkonie]

You need to supply title=True as in the original implementation to ensure the name is returned capitalized. This was present in the original implementation. Please test these features to ensure they appear correct before submitting a pr.

[gromdimon]

I'm sorry, that I overlooked it! Now it should be fixed

[gromdimon]

It looks like some 'label' lines are now too long. Although Black and Flake8 do not raise any issues, this definitely doesn't follow conventions. There are multiple ways to solve this problem: reformatting the string using parentheses (), using the '+' syntax, adding a helper method, or introducing some temporary variables before appending the link.

The question now is: how should I address this issue?

[mikkonie]

It looks like some 'label' lines are now too long. Although Black and Flake8 do not raise any issues, this definitely doesn't follow conventions. There are multiple ways to solve this problem: reformatting the string using parentheses (), using the '+' syntax, adding a helper method, or introducing some temporary variables before appending the link.

The question now is: how should I address this issue?

This is a good point. You have "wrapped" the code inside the format string and strings are exempt from line length formatting in black. It is possible to do the following:

'label': f'Create '
'{get_display_name(PROJECT_TYPE_PROJECT, title=True)}',

That reduces line length and is accepted by black. Probably the best way unless you want to use the old style format() or get the title into a variable before inserting it into the string.

[mikkonie]

I had one minor comment, plus I gave a hint on how to fix the line length issue in the pull request comments. Otherwise this looks fine and once these small things are fixed, I'll merge.

[mikkonie]

We could get the string for the current project's type into a variable and use it both here and in the "Update Project" link. That would save us from calling the same method twice with identical input.