Merge pull request #1053 from biigle/patch-1

Fix basic report script for empty volume
biigle · Jan 20, 2025 · c3fc384 · c3fc384
2 parents 02713f6 + c3ac106
commit c3fc384
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/Services/Reports/Volumes/ImageAnnotations/BasicReportGenerator.php b/app/Services/Reports/Volumes/ImageAnnotations/BasicReportGenerator.php
@@ -90,9 +90,11 @@ protected function query()
      * @param string $title The title to put in the first row of the CSV
      * @return CsvFile
      */
-    protected function createCsv($labels, $title = '')
+    protected function createCsv($labels, $title = "\n")
     {
         $csv = CsvFile::makeTmp();
+        // The title must not be empty as the Python
+        // script expects one line as title.
         $csv->put($title);
 
         foreach ($labels as $label) {

diff --git a/tests/php/Services/Reports/Volumes/ImageAnnotations/BasicReportGeneratorTest.php b/tests/php/Services/Reports/Volumes/ImageAnnotations/BasicReportGeneratorTest.php
@@ -41,7 +41,7 @@ public function testGenerateReport()
 
         $mock->shouldReceive('put')
             ->once()
-            ->with('');
+            ->with("\n");
 
         $mock->shouldReceive('putCsv')
             ->once()