Add video info view #1014
Open
Add video info view #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
requested changes
Dec 18, 2024
| @@ -335,7 +340,7 @@ | |||
| ]); | |||
|
|
|||
| // Legacy support. | |||
| $router->redirect('videos/{id}', '/videos/{id}/annotations'); | |||
| $router->redirect('video-annotate/{id}', '/videos/{id}/annotations'); | |||
There was a problem hiding this comment.
This redirect doesn't make sense any more. I can be removed.
Comment on lines
+25
to
+48
| @if ($video->taken_at) | ||
| <tr> | ||
| <th>Created</th> | ||
| @if (is_array($video->taken_at)) | ||
| @foreach ($video->taken_at as $value) | ||
| <td>{{ $value }}</td> | ||
| @endforeach | ||
| @else | ||
| <td>{{ $video->taken_at }}</td> | ||
| @endif | ||
| </tr> | ||
| @endif | ||
| @foreach ($metadata as $key => $field) | ||
| <tr> | ||
| <th>{{ $metadataMap[$key] }}</th> | ||
| @if (is_array($field)) | ||
| @foreach ($field as $value) | ||
| <td>{{ $value }}</td> | ||
| @endforeach | ||
| @else | ||
| <td>{{ $value }}</td> | ||
| @endif | ||
| </tr> | ||
| @endforeach |
There was a problem hiding this comment.
Video metadata may be an array, too. This will produce an "array to string conversion" error here. How could we show these values here in a meaningful way? Maybe show the min/max values of each field only?
| <div class="panel-heading"> | ||
| <h3 class="panel-title">Video information</h3> | ||
| </div> | ||
| <div class="panel-body table-responsive"> |
There was a problem hiding this comment.
No need to wrap this into a .panel-body, this will only add an unnecessary padding around the table (see images/index/meta.blade.php).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in Footprint / laser point detection for videos #70, we would like to add a new info view for videos, as for images, with metadata and, later, computed laser points info.