Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check moov atom position #1056

Merged
merged 15 commits into from
Jan 28, 2025
Merged

Check moov atom position #1056

merged 15 commits into from
Jan 28, 2025

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Jan 21, 2025

Add check to validate moov atom position and show error message.

Closes #983.

@lehecht lehecht changed the title Moov atom bug Check moov atom position Jan 21, 2025
@lehecht lehecht requested a review from mzur January 21, 2025 12:45
@lehecht lehecht requested a review from mzur January 27, 2025 08:48
mzur
mzur approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In a002ffc I updated the manual article to explain a little better what all the fixing is about.

@mzur mzur merged commit 6999c17 into master Jan 28, 2025
6 checks passed
@mzur mzur deleted the moovAtomBug branch January 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzur mzur mzur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MP4 moov atom validation
2 participants
@lehecht @mzur