Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing long labeltree description #948

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Oct 11, 2024

Truncates long labeltree descriptions to prevent overflowing content.

Closes #925.

@lehecht lehecht requested a review from mzur October 11, 2024 13:23
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So this is only a problem if there are no spaces in the description and the browser can't break the text, right? This will probably be more of an edge case.

I think the description should be displayed in full in the project list. This is what the description is for, after all. So instead of truncating it all the time (even if it has spaces and can be broken nicely), maybe we should rather use word-wrap: break-word instead. This will break long words without spaces so they don't overflow the element.

While you are at it, you could do the same with the label tree title. And also on the label tree overview page:

image

@lehecht lehecht requested a review from mzur October 17, 2024 05:43
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged #953 into this branch to fix the JS action errors.

@lehecht lehecht requested a review from mzur October 17, 2024 08:09
@mzur mzur merged commit 1365b19 into master Oct 17, 2024
6 checks passed
@mzur mzur deleted the fix-long-lt-description branch October 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LabelTrees with long descriptions overflow in Project Labtree view
2 participants