Add test, fix PR based on feedback

bikeshaving · Nov 7, 2023 · 4ac5d8b · 4ac5d8b
1 parent 757abf0
commit 4ac5d8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/src/dom.ts b/src/dom.ts
@@ -14,9 +14,8 @@ export const impl: Partial<RendererImpl<Node, string>> = {
 	scope(
 		xmlns: string | undefined,
 		tag: string | symbol,
-		props: any
+		props: Record<string, any>
 	): string | undefined {
-		// TODO: Should we handle xmlns???
 		switch (tag) {
 			case Portal:
 				xmlns = undefined;
@@ -26,7 +25,7 @@ export const impl: Partial<RendererImpl<Node, string>> = {
 				break;
 		}
 
-		return props?.xmlns ?? xmlns;
+		return props.xmlns || xmlns;
 	},
 
 	create(
@@ -74,7 +73,7 @@ export const impl: Partial<RendererImpl<Node, string>> = {
 		}
 
 		// TODO: extract props from nodes
-		return {props, children};
+		return { props, children };
 	},
 
 	patch(
@@ -106,7 +105,7 @@ export const impl: Partial<RendererImpl<Node, string>> = {
 						style.cssText = "";
 					}
 
-					for (const styleName in {...(oldValue as {}), ...(value as {})}) {
+					for (const styleName in { ...(oldValue as {}), ...(value as {}) }) {
 						const styleValue = value && (value as any)[styleName];
 						if (styleValue == null) {
 							style.removeProperty(styleName);
@@ -383,6 +382,6 @@ export const renderer = new DOMRenderer();
 
 declare global {
 	module Crank {
-		interface EventMap extends GlobalEventHandlersEventMap {}
+		interface EventMap extends GlobalEventHandlersEventMap { }
 	}
 }
diff --git a/test/svg.tsx b/test/svg.tsx
@@ -77,9 +77,14 @@ test("foreignObject", () => {
 		document.body,
 	);
 	Assert.ok(document.body.firstChild instanceof SVGElement);
-	Assert.ok(
-		document.body.firstChild!.firstChild!.firstChild instanceof HTMLElement,
-	);
+
+	const foreignObject = document.body.firstChild!.firstChild!;
+	Assert.ok(foreignObject instanceof SVGElement);
+	Assert.is(foreignObject.namespaceURI, "http://www.w3.org/2000/svg");
+
+	const div = foreignObject.firstChild! as HTMLElement;
+	Assert.ok(div instanceof HTMLElement);
+	Assert.is(div.namespaceURI, "http://www.w3.org/1999/xhtml");
 });
 
 test("classes", () => {