Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed version of the theme #37

Open
osdiab opened this issue Aug 19, 2024 · 5 comments
Open

Zed version of the theme #37

osdiab opened this issue Aug 19, 2024 · 5 comments

Comments

@osdiab
Copy link

osdiab commented Aug 19, 2024

Zed supports background colors for syntax highlighting, would love to use Flatwhite on this new school editor 😎

@bobuk
Copy link

bobuk commented Nov 27, 2024

Just tried and checked the json schema for themes, Zed still doesn't support different background colors for syntax highlighting :(

@klemola
Copy link

klemola commented Nov 28, 2024

@bobuk https://github.com/bIaqat/flat-theme-zed does exist, but it's currently broken: selecting text does not change the background of a syntax highlight span.

@biletskyy
Copy link
Owner

I'm currently started using Zed myself but was under impression that it doesn't support background colors for syntax highlightning. @klemola thanks for example, really curious how it works. Will have a look.

@bobuk
Copy link

bobuk commented Nov 29, 2024

@klemola oh thank you.
My quick research shows that zed themes json schema is wrong :)
HighlightStyleContent shows only three supported fields: color, font_style, and font_weight. Author of flat-theme-zed used background_color and it's working like a charm. In the code its clear that it's just a error in json schema.
So YES, flatwhite can be ported to zed at least partially

@bobuk
Copy link

bobuk commented Dec 3, 2024

please note, that latest Zed release fixes the problem:
https://zed.dev/schema/themes/v0.2.0.json

HightlightStyleContent officially have background_color.

@biletskyy if you're working on porting, I'm 100% ready to test or to help with something.

І дякую за роботу, багато років і мегабайти мого коду були хороші завдяки flatwhite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants