Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed android 6.0+ fetch HEAD network error bugs #25

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

oneroundseven
Copy link

@coveralls
Copy link

coveralls commented May 24, 2018

Coverage Status

Coverage decreased (-1.4%) to 92.114% when pulling daf0734 on oneroundseven:master into a2880e9 on billmalarky:master.

@billmalarky
Copy link
Owner

Looks like there are linting errors. To problem I can quickly solve those with my own commit.

The larger issue here, is this is not a solution to the bug.

A patch will need to be applied in this function: https://github.com/billmalarky/react-native-image-cache-hoc/blob/master/lib/FileSystem.js#L186-L227

For what it's worth, you will not run into this issue so long as the images you are using for CacheableImage have an extension in the url like .jpg/.png.gif etc.

@oneroundseven
Copy link
Author

but some server image url not has the .jpg/.png ...
and the server return fetch is correct, but fetch not correct call back with the issue error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants