Feature: share plugin #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasRichel
force-pushed
the
feature/share-plugin
branch
from
911e157 to
8e99ddd
Compare
Amoki
reviewed
Aug 30, 2021
| ); | ||
| const jsonResponse = await response.json(); | ||
| this.shareRows = jsonResponse.map(share => { | ||
| delete share.camera_settings; |
There was a problem hiding this comment.
It seems to be a hackathon weird stuff x)
There was a problem hiding this comment.
Maybe this was to avoid some "reactivity overhead" with Vue or to save some memory usage. (?)
But I didn't test this assumption.
| body.expires_at = this.expirationDate.toISOString(); | ||
| } else { | ||
| let date = new Date(); | ||
| date.setFullYear(2099); |
There was a problem hiding this comment.
this should be set in backend imho
There was a problem hiding this comment.
OK, were can I find the backend source code to have a look ?
There was a problem hiding this comment.
…nd instead of client side
NicolasRichel
force-pushed
the
feature/share-plugin
branch
from
657c597 to
f59d4ec
Compare
NicolasRichel
force-pushed
the
feature/share-plugin
branch
from
f59d4ec to
d1e36b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin allows to share a given model view (with camera settings) by generating an iframe URL to directly access the view.