Feature/search in select #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amoki
requested changes
Oct 5, 2023
Amoki
approved these changes
Oct 5, 2023
NicolasRichel
requested changes
Oct 6, 2023
NicolasRichel
approved these changes
Oct 6, 2023
Kurtil
reviewed
Oct 6, 2023
Kurtil
requested changes
Oct 6, 2023
Amoki
requested changes
Oct 6, 2023
| return option.toLowerCase().includes(lowerCaseSearchText); | ||
| }); | ||
| return this.options.filter(option => | ||
| option.toLowerCase().includes(lowerCaseSearchText), |
There was a problem hiding this comment.
Suggested change
| option.toLowerCase().includes(lowerCaseSearchText), | |
| option.toLowerCase().includes(lowerCaseSearchText) |
There was a problem hiding this comment.
Curiosity question: is this comma a https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Operators/Comma_operator in this case?
| return option.toLowerCase().includes(lowerCaseSearchText); | ||
| }); | ||
| return this.options.filter(option => | ||
| option.toLowerCase().includes(lowerCaseSearchText), |
Kurtil
approved these changes
Oct 6, 2023
|
🎉 This PR is included in version 2.1.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
# [2.1.0](v2.0.0...v2.1.0) (2024-06-27) ### chore * add dependabot.yml ([db3061d](db3061d)) * update .vscode/settings.json ([9998126](9998126)) ### documentation * Update neutral colors (#352) ([1b2ccc0](1b2ccc0)), closes [#352](#352) ### MINOR * add BIMDataList component (#358) ([1c6f115](1c6f115)), closes [#358](#358) * add search bar into BIMDataDropdownList component (#316) ([e860b40](e860b40)), closes [#316](#316) * create BIMDataInputOutlined component and add documentation (#329) ([3ecf39f](3ecf39f)), closes [#329](#329) * feat: add BIMDataTree component (#343) ([63111fa](63111fa)), closes [#343](#343) * Feature/add multiple icons (#330) ([8edd657](8edd657)), closes [#330](#330) * Feature/bim data table filter (#336) ([6f58f84](6f58f84)), closes [#336](#336) * Feature/search in select (#315) ([a6974ad](a6974ad)), closes [#315](#315) ### PATCH * add 'indeterminate' value in haeder checkbox for selectable table elements (#355) ([fd193d8](fd193d8)), closes [#355](#355) * add createSpace & createZone icons ([1db62e5](1db62e5)) * add disabled props for BIMDataSearch component & doc (#331) ([b5b83b0](b5b83b0)), closes [#331](#331) * add filterFunction & documentation (#353) ([d2740f0](d2740f0)), closes [#353](#353) * add FolderLocation icon (#361) ([9a36604](9a36604)), closes [#361](#361) * Add illustrations for Dwg & plan shortcuts (#323) ([0a795c1](0a795c1)), closes [#323](#323) * add rotate icon (#324) ([405f324](405f324)), closes [#324](#324) * better slider UX - cursor pointer + more height (#326) ([7500ba8](7500ba8)), closes [#326](#326) * BIMDataList fixes (#360) ([984ef8c](984ef8c)), closes [#360](#360) * check if empty or 0 (#327) ([39fb094](39fb094)), closes [#327](#327) * chore: keep only the most used file icons (#335) ([8c4fd1e](8c4fd1e)), closes [#335](#335) * chore(deps-dev): bump postcss from 8.4.29 to 8.4.31 (#317) ([d90902c](d90902c)), closes [#317](#317) * feat(bimdata-tree): add dragAndDrop prop to enable/disable drag and drop feature (#349) ([65a8aad](65a8aad)), closes [#349](#349) * feat(icons): add monochrome structure icon ([cbe2d6c](cbe2d6c)) * feat(icons): add plan icon, remove deploy icon (#348) ([ce14cbc](ce14cbc)), closes [#348](#348) * feat(icons): add space2 and zone2 icons (#346) ([72e6eb0](72e6eb0)), closes [#346](#346) * feat(radio): add slot to customize radio button label (#364) ([912c5f6](912c5f6)), closes [#364](#364) * feat(tree): add visibleRef to bimdata tree node (#351) ([9f33b5f](9f33b5f)), closes [#351](#351) * fix list margin into BIMDataSelectMulti ([9745277](9745277)) * Fix warning icon (#354) ([6434b78](6434b78)), closes [#354](#354) * fix: BIMDataTree node children components ([161c745](161c745)) * Fix/search in components (#321) ([e77ac42](e77ac42)), closes [#321](#321) * remove circular dependency in BIMDataTree (#345) ([545bca0](545bca0)), closes [#345](#345) * remove specific style (#322) ([449ec51](449ec51)), closes [#322](#322) * remove unnecessary drop down heights (#342) ([091c389](091c389)), closes [#342](#342) * rename props to clear search on leave (#320) ([5414a7c](5414a7c)), closes [#320](#320) * use selectedState instead of isSelected for deselect all files if one row is selected (#356) ([9319e28](9319e28)), closes [#356](#356)
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries that use the DS (need to merge first)
Repos that use the DS (and that I need to check after libraries have been merged)