-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Photopshere Viewer #461
Open
NicolasRichel
wants to merge
7
commits into
develop
Choose a base branch
from
feature/panorama-viewer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
2 times, most recently
from
July 2, 2024 08:16
a900f9e
to
9c9ad04
Compare
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
from
July 26, 2024 14:08
9c9ad04
to
22f6a90
Compare
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
3 times, most recently
from
September 2, 2024 15:31
0fc41dd
to
74f5815
Compare
NicolasRichel
force-pushed
the
develop
branch
13 times, most recently
from
September 3, 2024 08:28
a0d6202
to
60a63ae
Compare
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
2 times, most recently
from
September 6, 2024 13:14
12ef0ba
to
c0ff322
Compare
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
from
November 14, 2024 08:55
c0ff322
to
4ae5438
Compare
NicolasRichel
changed the title
[WIP] Feature: Photopshere Viewer
Feature: Photopshere Viewer
Nov 21, 2024
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
2 times, most recently
from
November 21, 2024 14:49
9f6d9b2
to
5e54483
Compare
It seems to be working well; however, we have some issues with the BCF. It doesn't load the correct photo nor position the camera properly when trying to view a BCF on a 360 photo. @NicolasRichel |
GabBimdata
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf my comment
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
from
November 28, 2024 14:01
5a9d398
to
0bd1ad8
Compare
Amoki
reviewed
Nov 29, 2024
src/components/specific/files/files-table/file-actions-cell/FileActionsCell.vue
Outdated
Show resolved
Hide resolved
NicolasRichel
force-pushed
the
feature/panorama-viewer
branch
from
December 5, 2024 13:41
5e1f3aa
to
5656c2a
Compare
Kurtil
approved these changes
Dec 5, 2024
Co-authored-by: Gaëtan LAGIER <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated Viewer PR: https://github.com/bimdata/viewer/pull/1105
Dev Platform URL: https://platform-dev-panorama-viewer.bimdata.io/
Types of changes
Checklist