Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Photopshere Viewer #461

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

NicolasRichel
Copy link
Member

@NicolasRichel NicolasRichel commented Jun 28, 2024

Description

Associated Viewer PR: https://github.com/bimdata/viewer/pull/1105

Dev Platform URL: https://platform-dev-panorama-viewer.bimdata.io/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have tested my code.
  • I want to run the tests for the commits of this PR

@NicolasRichel NicolasRichel self-assigned this Jun 28, 2024
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch 2 times, most recently from a900f9e to 9c9ad04 Compare July 2, 2024 08:16
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch from 9c9ad04 to 22f6a90 Compare July 26, 2024 14:08
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch 3 times, most recently from 0fc41dd to 74f5815 Compare September 2, 2024 15:31
@NicolasRichel NicolasRichel force-pushed the develop branch 13 times, most recently from a0d6202 to 60a63ae Compare September 3, 2024 08:28
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch 2 times, most recently from 12ef0ba to c0ff322 Compare September 6, 2024 13:14
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch from c0ff322 to 4ae5438 Compare November 14, 2024 08:55
@NicolasRichel NicolasRichel changed the title [WIP] Feature: Photopshere Viewer Feature: Photopshere Viewer Nov 21, 2024
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch 2 times, most recently from 9f6d9b2 to 5e54483 Compare November 21, 2024 14:49
@Amoki Amoki requested a review from GabBimdata November 21, 2024 15:02
@GabBimdata
Copy link

It seems to be working well; however, we have some issues with the BCF. It doesn't load the correct photo nor position the camera properly when trying to view a BCF on a 360 photo. @NicolasRichel

Copy link

@GabBimdata GabBimdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf my comment

@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch from 5a9d398 to 0bd1ad8 Compare November 28, 2024 14:01
@NicolasRichel NicolasRichel force-pushed the feature/panorama-viewer branch from 5e1f3aa to 5656c2a Compare December 5, 2024 13:41
src/state/models.js Outdated Show resolved Hide resolved
Co-authored-by: Gaëtan LAGIER <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants