Merge pull request #8 from binance/v0.5.0

v0.5.0 release
binance · May 22, 2023 · 5aaa872 · 5aaa872
2 parents 2806349 + 2c02e73
commit 5aaa872
Show file tree

Hide file tree

Showing 7 changed files with 217 additions and 152 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,12 @@
 # CHANGELOG
 
+## v0.5.0
+- Default for `ed25519` keys
+- Change app name
+
 ## v0.4.0
 - Add support for `ed25519` keys
-  
+
 ## v0.3.1
 - Fix tooltip on canceled save
 - Update dependencies

diff --git a/README.md b/README.md
@@ -1,30 +1,30 @@
-# Key Pair Generator
+# Asymmetric Key Generator
 
-This simple tool can be used to generate an RSA and Ed25519 PKCS#8 key pairs (private and public key).
+This simple tool can be used to generate an Ed25519 PKCS#8 and RSA key pairs (private and public key).
 
 There's two methods to run the tool, you can either download or build from source code.
 
 ## Download
-Prebuild apps can be found in [Releases](https://github.com/binance/rsa-key-generator/releases).
+Prebuild apps can be found in [Releases](https://github.com/binance/asymmetric-key-generator/releases).
 
 To verify the package's integrity, download both the app and the checksum file to the same directory:
 
 ```shell
--rw-r--r--@  1 john  staff   156M 18 Nov 17:02 RSAKeyGenerator-0.3.0-universal.dmg
--rw-r--r--@  1 john  staff   102B 18 Nov 19:01 RSAKeyGenerator-0.3.0-universal.dmg.CHECKSUM
+-rw-r--r--@  1 john  staff   156M 18 Nov 17:02 AsymmetricKeyGenerator-0.5.0-universal.dmg
+-rw-r--r--@  1 john  staff   102B 18 Nov 19:01 AsymmetricKeyGenerator-0.5.0-universal.dmg.CHECKSUM
 ```
 
 Then run sha256 checksum:
 
 ```shell
-sha256sum -c RSAKeyGenerator-0.3.0-universal.dmg.CHECKSUM
+sha256sum -c AsymmetricKeyGenerator-0.5.0-universal.dmg.CHECKSUM
 ```
 
-If it passes the integrity check, it'll return `RSAKeyGenerator-0.3.0-universal.dmg: OK`
+If it passes the integrity check, it'll return `AsymmetricKeyGenerator-0.5.0-universal.dmg: OK`
 
 ## Build from source code
 
-Obtain the source code locally and go through the following steps: 
+Obtain the source code locally and go through the following steps:
 
 ```javascript
 
@@ -43,7 +43,7 @@ npm run dist
 
 1. Open the app;
 
-2. Choose the key type; Recommend to keep the default value (` RSA 2048`), then click the button `Generate Key Pair`;
+2. Choose the key type; Recommend to keep the default value (`Ed25519`), then click the button `Generate Key Pair`;
 
 3. Below on the left column is the `Private Key`, which should be stored in a secure location on your local disk (by using the `Save` button) and must never be shared with anyone;
 

diff --git a/assets/html/index.html b/assets/html/index.html
@@ -27,9 +27,9 @@ <h1 class="text-3xl font-bold">Generate</h1>
         <div class="grid grid-cols-3 gap-x-8 w-3/4 py-2">
           <div>
             <select id="select-keyType" class="select select-bordered">
+              <option value="ed25519">Ed25519</option>
               <option value="rsa-2048">RSA (2048 bits)</option>
               <option value="rsa-4096">RSA (4096 bits)</option>
-              <option value="ed25519">Ed25519</option>
             </select>
           </div>
           <div class="col-span-2 pl-4">

diff --git a/config/electron-builder.js b/config/electron-builder.js
@@ -2,8 +2,8 @@ const os = require('os')
 const { notarize } = require('@electron/notarize')
 
 const config = {
-  appId: 'rsa-key-generator',
-  productName: 'RSAKeyGenerator',
+  appId: 'asymmetric-key-generator',
+  productName: 'AsymmetricKeyGenerator',
   mac: {
     target: {
       target: 'dmg',
@@ -35,7 +35,7 @@ const config = {
     const appName = context.packager.appInfo.productFilename;
 
     return await notarize({
-      appBundleId: 'com.binance.RSAKeyGenerator',
+      appBundleId: 'com.binance.AsymmetricKeyGenerator',
       appPath: `${appOutDir}/${appName}.app`,
       appleId: process.env.NOTARIZE_APPLE_ID,
       appleIdPassword: process.env.NOTARIZE_APPLE_PASSWORD,