Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ReefSet dataset #16

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Adding ReefSet dataset #16

merged 2 commits into from
Sep 12, 2024

Conversation

BenUCL
Copy link
Contributor

@BenUCL BenUCL commented Sep 11, 2024

Adding ReefSet as per instructions in ReadMe

@Cangonin Cangonin self-requested a review September 11, 2024 11:39
Copy link
Collaborator

@Cangonin Cangonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! 🔥 I have two small requests:

  1. The creators fields is supposed to be an array of strings, not a string. The reason is to have a consistent display of the datasets creators in the webapp for all datasets. Could you replace the value of this field by the following snippet?
 "creators": [
    "Ben Williams",
    "Bart van Merriënboer",
    "Vincent Dumoulin",
    "Jenny Hamer",
    "Abram B. Fleishman",
    "Matthew McKown",
    "Jill E. Munger",
    "Aaron N. Rice",
    "Ashlee Lillis",
    "Clemency E. White",
    "Catherine A. D. Hobbs",
    "Tries B. Razak",
    "Kate E. Jones",
    "Tom Denton"
  ],
  1. Is there a reason why you specified an additional description but no description? If not, what about leaving the additional description field empty and filling the description field instead?

@BenUCL
Copy link
Contributor Author

BenUCL commented Sep 11, 2024

Thanks, I've made the changes!

@Cangonin Cangonin merged commit 72aed02 into bioacoustic-ai:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants