Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include BIRDeep_AudioAnnotations #21

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

GrunCrow
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Cangonin Cangonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I see that the file doesn't have the .json extension, and that the authors field is not json parsable. I applied the necessary changes, could you replace the file you added by the one I attach here? I also took the freedom to modify other fields, tell me if something is incorrect.

I also see that the names of some fields are ambiguous (totalDuration, sampleRate), I will add the unit for more clarity in a next pull request. That way, it will be clearer that the duration has the unit of hours for example.

BIRDeep_AudioAnnotations.json

@GrunCrow
Copy link
Contributor Author

Thank you very much for the help!

I created a new commit changing the file type (sorry about that, just created the json directly in github web).

I also edited the README.md as for several authors there is no example (Added how it would be with 3 authors).

I checked everything and it seems correct. Thank you (again)!

Copy link
Collaborator

@Cangonin Cangonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about the creators field in the README, thank you for adding one more example. Everything seems good!

@Cangonin Cangonin merged commit 139d94f into bioacoustic-ai:main Sep 24, 2024
2 checks passed
@GrunCrow GrunCrow deleted the patch-1 branch September 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants