Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #34 - Print the additional platforms in the description table column #36

Merged
merged 9 commits into from
Nov 30, 2024
Merged

Issue #34 - Print the additional platforms in the description table column #36

merged 9 commits into from
Nov 30, 2024

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Nov 27, 2024 •
edited
Loading

Prints the optional additional platforms in the description column of the Index table.
Also prints the platforms in the recipe's details page.

recipe-details
index-page

This is still work in progress! I'll try to make the Index table more dynamic by using https://datatables.net/

@martin-g
Issue bioconda#34 - Print the additional platforms in the `descriptio…
8cb76d5 
…n` table column

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g marked this pull request as draft November 27, 2024 14:52
@martin-g
Use https://datatables.net to render the HTML table with the recipe i…
e8ceb5c 
…ndex

The benefit of using DataTables.net is that it renders the DOM
dynamically showing just a subset/page of the data at a time.
It also provides filtering, sorting and many more settings
(https://datatables.net/reference/option/)

Also on top I have added a small table that shows the number of recipes
with additional platforms and their ratio to the total.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

martin-g commented Nov 28, 2024 •
edited
Loading

Here is the new version of the Package Index page based on DataTables.net:
package-index-datatables net

I tried to keep it similar to the current UI of that page but if you have ideas how to improve its user experience I'll be glad to implement them!

You could try it at https://bc2a-212-50-92-101.ngrok-free.app/conda-package_index.html
Note: it runs on my dev machine, so it might be broken sometimes or offline.

@martin-g
Simplify the handling of the recipes' extra details
eda8dec 
There is no need to keep them in data['objects']

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

martin-g commented Nov 28, 2024 •
edited
Loading

package-index-datatables

@martin-g
Add recipe latest version to the table
2b921e5 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@emiliofernandes
Copy link

Very cool, @martin-g !
The table looks very good to me!
Why does it show just 63 recipes ?

@bgruening
Copy link
Member

Cool, I like it :)

@martin-g
Copy link
Contributor Author

Why does it show just 63 recipes ?

Because building all recipes takes a lot of time :-)
I use BIOCONDA_FILTER_RECIPES=63 make html to build just 63 of them. A random number.

I just built them all:
package-index-datatables

@martin-g
Copy link
Contributor Author

package-index-datatables

@martin-g martin-g marked this pull request as ready for review November 28, 2024 13:32
@martin-g
Show 50 recipes per page by default.
2dca014 
Remove debug statement

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Add a check for non-empty id before trying to find it in the document
15ece24 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Add info about noarch recipes to the package index page
f854a6f 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

Added info about noarch recipes:

package-index-datatables

Any ideas how to detect whether a recipe is enabled for linux-64 and osx-64 ? Those are implicit, i.e. not explicitly listed in meta.yaml, and they could be disabled via build > skip: True # [...]

@martin-g
Copy link
Contributor Author

I think I figured how to list all available platform builds for a recipe by using the RepoData:

package-index-datatables

@martin-g
Copy link
Contributor Author

I don't have more ideas for improvements for this PR!

bgruening
bgruening approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and I don't have anything to complain :) Great stuff @martin-g!

@bgruening bgruening merged commit 471d2b1 into bioconda:main Nov 30, 2024
2 checks passed
@daler
Copy link
Member

daler commented Dec 2, 2024

@martin-g this is great, thank you!

@emiliofernandes
Copy link

This is much more than what I asked for in #34! Thank you, @martin-g !

@martin-g martin-g deleted the arch-filtering branch December 2, 2024 07:26
@martin-g
Copy link
Contributor Author

martin-g commented Dec 2, 2024

I'm glad you all like it! :-)

@martin-g martin-g mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-g @emiliofernandes @bgruening @daler