Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenEra Conda Recipes Submission #51721

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
d945bd5
Committer: Anupam Gautam <[email protected]>
Oct 24, 2024
6fdfb3b
Merge branch 'bioconda:master' into update_my_recipe
AnupamGautam Oct 25, 2024
4ab01ae
Update recipes/tipp/build.sh
AnupamGautam Oct 25, 2024
63b05b4
Update recipes/tipp/build.sh
AnupamGautam Oct 25, 2024
ec0b3c9
Update recipes/tipp/build.sh
AnupamGautam Oct 25, 2024
61cdfda
Update recipes/tipp/build.sh
AnupamGautam Oct 25, 2024
9ed0cdd
Update recipes/tipp/build.sh
AnupamGautam Oct 25, 2024
2c0a077
Update recipes/tipp/meta.yaml
AnupamGautam Oct 25, 2024
c9d79ab
Merge branch 'bioconda:master' into update_my_recipe
AnupamGautam Oct 25, 2024
01a006d
Committer: Anupam Gautam <[email protected]>
Oct 25, 2024
c93d20d
Merge branch 'bioconda:master' into update_my_recipe
AnupamGautam Oct 25, 2024
8f24e82
Merge branch 'master' into update_my_recipe
AnupamGautam Oct 25, 2024
726f73b
Committer: Anupam Gautam <[email protected]>
Oct 25, 2024
6ca983f
Merge branch 'master' into update_my_recipe
AnupamGautam Oct 25, 2024
4fea052
Merge branch 'bioconda:master' into update_my_recipe
AnupamGautam Oct 28, 2024
455eaf3
GenEra conda recipes
Oct 28, 2024
7d21180
removed genera files
Oct 28, 2024
2e331f5
GenEra conda recipe
Oct 28, 2024
1c55c53
cleaning
Oct 28, 2024
8554955
Merge branch 'master' into update_my_recipe2
AnupamGautam Oct 28, 2024
7a4152e
Merge branch 'master' into update_my_recipe2
AnupamGautam Oct 28, 2024
103ce91
Merge branch 'bioconda:master' into update_my_recipe2
AnupamGautam Oct 28, 2024
579c149
update
Oct 28, 2024
759c679
Merge branch 'master' into update_my_recipe2
aliciaaevans Oct 29, 2024
5569775
Merge branch 'bioconda:master' into update_my_recipe2
AnupamGautam Oct 29, 2024
0305a7c
python updated
Oct 29, 2024
81192f3
changes added
Nov 1, 2024
448443e
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 1, 2024
88db21b
added test and abSENSE release
Nov 4, 2024
13ba689
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 4, 2024
449f892
added test and abSENSE release
Nov 4, 2024
bea8361
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 5, 2024
cb2bf56
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 7, 2024
463df26
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 11, 2024
7e87ce3
update
Nov 15, 2024
131d9d3
Merge branch 'master' into update_my_recipe2
richard-burhans Nov 15, 2024
64308f9
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 16, 2024
43ab6b9
update
Nov 16, 2024
0203536
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 16, 2024
c34e66e
Update recipes/genera/meta.yaml
AnupamGautam Nov 18, 2024
50c9c61
Update recipes/genera/meta.yaml
AnupamGautam Nov 18, 2024
4a1412a
Update meta.yaml
AnupamGautam Nov 18, 2024
f183729
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 18, 2024
f4babdd
Solved abSENSE License issue
AnupamGautam Nov 18, 2024
519c139
Merge branch 'master' into update_my_recipe2
AnupamGautam Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions recipes/genera/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/bin/bash

# Exit on any error
set -ex

# Ensure all main scripts are executable
chmod +x genEra Erassignment hmmEra tree2ncbitax FASTSTEP3R test_installation.sh
bgruening marked this conversation as resolved.
Show resolved Hide resolved

#Move the main Run_abSENSE.py script

mv abSENSE/Run_abSENSE.py .
chmod +x Run_abSENSE.py

# Define the Conda binary path
CONDABIN="${PREFIX}/bin"

# Ensure the directory exists
mkdir -p "$CONDABIN"


# Move executables to the Conda binary directory
mv genEra "$CONDABIN"
mv Erassignment "$CONDABIN"
mv Run_abSENSE.py "$CONDABIN"
mv hmmEra "$CONDABIN"
mv tree2ncbitax "$CONDABIN"
mv FASTSTEP3R "$CONDABIN"
mv test_installation.sh "$CONDABIN"

echo "Installation complete. Executables have been moved to ${CONDABIN}."
47 changes: 47 additions & 0 deletions recipes/genera/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{% set version = '1.4.2' %}

package:
name: genera
version: {{ version|replace('-', '_') }}

source:
- url: https://github.com/josuebarrera/GenEra/archive/refs/tags/v{{ version }}.tar.gz
sha256: acc49698b68151550b825c73f1f03dd268da2c73ecc7ac4c55eccb8bec5b1a54
- url: https://github.com/caraweisman/abSENSE/archive/refs/tags/v1.0.1.tar.gz
sha256: 853418e55c012c0dd409c97a70bbc9ecb69dfa7ccc94ec0f54d54ff99ec0e9f0
folder: abSENSE
Comment on lines +10 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Licensing issue with abSENSE component.

The abSENSE component currently lacks a proper license declaration. While the associated paper is open-access, the code itself needs an explicit license for redistribution in bioconda. This component should either:

  1. Be moved to a separate recipe once properly licensed, or
  2. Be removed until licensing is clarified

Would you like assistance in:

  1. Creating a separate recipe for abSENSE once licensed?
  2. Modifying this recipe to work without abSENSE?


build:
number: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package should be noarch generic I think

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

noarch: generic
run_exports:
- {{ pin_subpackage('genera', max_pin="x.x") }}
Comment on lines +14 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider removing the run_exports section.

Since this is a noarch: generic package, the run_exports section with pin_subpackage might be unnecessary and could lead to overly strict version constraints. This aligns with the previous comment from @bgruening about avoiding strict pins in Conda packages.

 build:
   number: 0
   noarch: generic
-  run_exports:
-    - {{ pin_subpackage('genera', max_pin="x.x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
number: 0
noarch: generic
run_exports:
- {{ pin_subpackage('genera', max_pin="x.x") }}
build:
number: 0
noarch: generic

Comment on lines +17 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unnecessary run_exports section.

Since this is a noarch: generic package, the run_exports section with pin_subpackage is unnecessary and could lead to overly strict version constraints.

 build:
   number: 0
   noarch: generic
-  run_exports:
-    - {{ pin_subpackage('genera', max_pin="x.x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run_exports:
- {{ pin_subpackage('genera', max_pin="x.x") }}


requirements:
host:
- python >=3.8,<3.9
run:
- python >=3.8,<3.9
- diamond >=2.1.10
- mmseqs2 =14.7e284
- foldseek =3.915ef7d
- scipy =1.7.3
- r-seqinr =4.2_16
- r-optparse =1.7.3
- r-bio3d =2.4_3
- r-tidyverse =1.3.2
- r-phytools >=0.6_99
- orthofinder =2.5.5
- ncbitax2lin =2.3.2
Comment on lines +21 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Revise dependency specifications.

Several adjustments needed to align with Conda best practices:

  1. Remove upper bound on Python version
  2. Add missing build dependencies
  3. Use minimum version constraints (>=) instead of exact pins where possible
 requirements:
   host:
-    - python >=3.8,<3.9
+    - python >=3.8
+    - pip
+    - setuptools
   run:
-    - python >=3.8,<3.9
+    - python >=3.8
     - diamond >=2.1.10
-    - mmseqs2 =14.7e284
+    - mmseqs2 >=14.7e284
-    - foldseek =3.915ef7d
+    - foldseek >=3.915ef7d
-    - scipy =1.7.3
+    - scipy >=1.7.3
-    - r-seqinr =4.2_16
+    - r-seqinr >=4.2_16
-    - r-optparse =1.7.3
+    - r-optparse >=1.7.3
-    - r-bio3d =2.4_3
+    - r-bio3d >=2.4_3
-    - r-tidyverse =1.3.2
+    - r-tidyverse >=1.3.2
     - r-phytools >=0.6_99
-    - orthofinder =2.5.5
+    - orthofinder >=2.5.5
-    - ncbitax2lin =2.3.2
+    - ncbitax2lin >=2.3.2
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
host:
- python >=3.8,<3.9
run:
- python >=3.8,<3.9
- diamond >=2.1.10
- mmseqs2 =14.7e284
- foldseek =3.915ef7d
- scipy =1.7.3
- r-seqinr =4.2_16
- r-optparse =1.7.3
- r-bio3d =2.4_3
- r-tidyverse =1.3.2
- r-phytools >=0.6_99
- orthofinder =2.5.5
- ncbitax2lin =2.3.2
host:
- python >=3.8
- pip
- setuptools
run:
- python >=3.8
- diamond >=2.1.10
- mmseqs2 >=14.7e284
- foldseek >=3.915ef7d
- scipy >=1.7.3
- r-seqinr >=4.2_16
- r-optparse >=1.7.3
- r-bio3d >=2.4_3
- r-tidyverse >=1.3.2
- r-phytools >=0.6_99
- orthofinder >=2.5.5
- ncbitax2lin >=2.3.2


test:
commands:
- genEra -h
- hmmEra -h
- test_installation.sh -h

about:
home: https://github.com/josuebarrera/GenEra
license: "GPL-3.0-or-later"
license_family: GPL3
summary: "Uncovering gene-family founder events during major evolutionary transitions in animals, plants and fungi using GenEra"