Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenEra Conda Recipes Submission #51721
base: master
Are you sure you want to change the base?
GenEra Conda Recipes Submission #51721
Changes from all commits
d945bd5
6fdfb3b
4ab01ae
63b05b4
ec0b3c9
61cdfda
9ed0cdd
2c0a077
c9d79ab
01a006d
c93d20d
8f24e82
726f73b
6ca983f
4fea052
455eaf3
7d21180
2e331f5
1c55c53
8554955
7a4152e
103ce91
579c149
759c679
5569775
0305a7c
81192f3
448443e
88db21b
13ba689
449f892
bea8361
cb2bf56
463df26
7e87ce3
131d9d3
64308f9
43ab6b9
0203536
c34e66e
50c9c61
4a1412a
f183729
f4babdd
519c139
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Licensing issue with abSENSE component.
The abSENSE component currently lacks a proper license declaration. While the associated paper is open-access, the code itself needs an explicit license for redistribution in bioconda. This component should either:
Would you like assistance in:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package should be noarch generic I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider removing the run_exports section.
Since this is a
noarch: generic
package, therun_exports
section withpin_subpackage
might be unnecessary and could lead to overly strict version constraints. This aligns with the previous comment from @bgruening about avoiding strict pins in Conda packages.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove unnecessary run_exports section.
Since this is a
noarch: generic
package, therun_exports
section withpin_subpackage
is unnecessary and could lead to overly strict version constraints.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Revise dependency specifications.
Several adjustments needed to align with Conda best practices:
📝 Committable suggestion