Use new Emperor formatting methods #383
Conversation
ElDeveloper
force-pushed
the
make-scavenge-emperor-non-embarrassing
branch
from
686fafe
to
d1a1ea0
Compare
ElDeveloper
changed the title
ElDeveloper
changed the title
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv |
|
@ElDeveloper something odd seems to happen when playing two different animations. By that I mean first (on the emperor UI) select gradient=month and trajectory=trajectory. Play the animation. Then change gradient to day. The lines connecting the samples on the emperor plot jump around. The table shows the end of the animations. The images were taken from the linked .qzv.
Here is the console. |
|
Thanks for bringing this up, I think this has to do with Emperor's animation trajectory rendering strategy. I just opened: biocore/emperor#787 |
There was a problem hiding this comment.
thanks @ElDeveloper! This looks good. @fedarko go ahead an merge this PR unless you have any further feedback.
There was a problem hiding this comment.
Thanks @ElDeveloper, this looks great! I have a few small suggestions for the top comment in the emperor-callbacks.js file, but this should be fine to merge as is.
| @@ -1,3 +1,7 @@ | |||
| /* | |||
| * This File is intended to be used only with Emperor | |||
| */ | |||
There was a problem hiding this comment.
I'd suggest adding a link to the Emperor docs on JS integration. Not sure what URL is preferred (https://github.com/biocore/emperor/blob/master/doc/source/js_integration.rst?), but would help make the code even clearer.
There was a problem hiding this comment.
Thanks, just added that link - which should be the most up-to-date since we currently depend on a development version of Emperor.
Co-authored-by: Marcus Fedarko <[email protected]>
…lDeveloper/empress into make-scavenge-emperor-non-embarrassing
|
Thanks all! |
|
Thanks @fedarko!
…On (Sep-25-20|18:08), Marcus Fedarko wrote:
Merged #383 into master.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://urldefense.com/v3/__https://github.com/biocore/empress/pull/383*event-3809906601__;Iw!!Mih3wA!XfN2I46NLzr5XgRdz_wjkY6nLiFQBOiPPLvuFkDYCZbF1e0pv1G2ygtAoCIUTLU$
|
Consolidates all the callbacks in a single file and implements the new methods that are being introduced here.
Note that this build is going to fail unless biocore/emperor#786 is merged.