Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk_scan barcode #512

Open
wants to merge 22 commits into
base: master-overhaul
Choose a base branch
from
Open

Conversation

raginirai553
Copy link
Contributor

No description provided.

return response


def get_sample_from_rack(token_info, rack_id):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mapping between samples and racks needs to be sensitive to the fact that samples can move from rack to rack. Right now, the code just assumes that there's a stable relationship, which results in issues when you test using different sample barcodes with the same rack ID. Retrieving the samples from a rack should only reflect the samples that were present at the most recent scan, not every sample that has ever been on the rack.

Also, please pluralize the function name to reflect that we expect multiple samples to exist on a rack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the issue!

microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0115.sql Outdated Show resolved Hide resolved
microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
@cassidysymons
Copy link
Collaborator

@raginirai553 We just merged a big set of changes into master-overhaul. Can you please back-out the changes to 0114.sql and rename 0115.sql to 0116.sql and update your working branch? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants