Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample summary project output #566

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Fix sample summary project output #566

merged 4 commits into from
Apr 2, 2024

Conversation

colts661
Copy link
Contributor

@colts661 colts661 commented Mar 4, 2024

@cassidysymons
Copy link
Collaborator

@colts661 When we address code that isn't working as intended, we like to add tests that verify the issue has been resolved and can be verified through automated methods. In this scenario, I think two tests would suffice to reflect that the adjustments are working as intended:

  1. When a user searches by project, assert that all samples returned include that project in the output. I'd recommend using a project ID in the database that has a relatively limited number of samples associated.
  2. When a user searches for a single barcode, all of its project associations are returned. Please use a barcode from the database that has at least two samples associated.

Other than that, looks good. Thanks!

@cassidysymons cassidysymons merged commit 1d4bb5d into biocore:master Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidysymons cassidysymons cassidysymons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample Summary always return "Unspecified" as project
2 participants
@colts661 @cassidysymons