Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external survey - skin scoring app #583

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

external survey - skin scoring app #583

wants to merge 8 commits into from

Conversation

ayobi
Copy link
Contributor

@ayobi ayobi commented Sep 19, 2024

No description provided.

cassidysymons
cassidysymons requested changes Sep 19, 2024
View reviewed changes
microsetta_private_api/api/_survey.py Outdated Show resolved Hide resolved
microsetta_private_api/api/_survey.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Outdated Show resolved Hide resolved
cassidysymons
cassidysymons requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@cassidysymons cassidysymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with the specific comments, can you please add unit tests that exercise the changes to any modified repos? Thanks.

microsetta_private_api/repo/sample_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidysymons cassidysymons cassidysymons requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayobi @cassidysymons