Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline tests #45

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Add offline tests #45

merged 7 commits into from
Feb 8, 2024

Conversation

jmetz
Copy link
Collaborator

@jmetz jmetz commented Feb 8, 2024

Also fixes #44

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for bioimageio-uploader ready!

Name Link
🔨 Latest commit 215696e
🔍 Latest deploy log https://app.netlify.com/sites/bioimageio-uploader/deploys/65c4e1df98ea570008f9a2c8
😎 Deploy Preview https://deploy-preview-45--bioimageio-uploader.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmetz jmetz requested a review from FynnBe February 8, 2024 14:14
@jmetz
Copy link
Collaborator Author

jmetz commented Feb 8, 2024

@FynnBe - do you think having the local test scripts on here makes sense?

If not I'll remove them again... but as it is they could be useful for other / future maintainers (at least in principle).

Of course they are not true tests... so should probably refactor them into a proper testing framework...

@jmetz
Copy link
Collaborator Author

jmetz commented Feb 8, 2024

NB also fixes #43

@FynnBe FynnBe merged commit 8a39e05 into main Feb 8, 2024
4 checks passed
@FynnBe FynnBe deleted the add-offline-tests branch February 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation issue with current format
2 participants