-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CAREamics CI Script #114
base: main
Are you sure you want to change the base?
Conversation
…appens in check_tool_compatibility
using from bioimageio.spec import load_model_description
from bioimageio.spec.model import AnyModelDescr # currently Union[v0_4.ModelDescr, v0_5.ModelDescr]
from bioimageio.spec.model.v0_5 import ModelDescr
# might raise ValueError for invalid or non-model descriptions
model: AnyModelDescr = load_model_description("affable-shark")
if isinstance(model, ModelDescr):
# v0_5.ModelDescr
...
else:
# v0_4.ModelDescr
... If you don't want to raise an exception on loading just yet you can also check from bioimageio.spec import InvalidDescr, load_description
resource = load_description("affable-shark")
if isinstance(resource, InvalidDescr):
resource.validation_summary.display()
raise ValueError("resource is invalid")
... # more type narrowing with `isinstance` like above... |
I would encourage you to focus on the model v0_5 implementation (and update any model descriptions still in v0_4 if needed, which is usually very little work, especially as there are not that many yet). |
|
As long as CAREamics is not released at all (I'm assuming 0.1.0 will be your first release) I would not run compatibility checks at all. The users will not benefiting from knowing a given model is compatible with CAREamics commit 13497234. edit:
I guess this is a non-issue if there will be a CAREamics version out. |
Thanks for the quick reply! Yes if I could skip v0.4 altogether that would be ideal since CAREamics can only create v0.5 descriptions. I will try your suggestions and get back to you if I have any questions!
We actually do have some releases, we are currently on 0.0.4. We are treating our 0th major minor version as an alpha version, so users have an easier installation process, with the understanding there can still be breaking changes up until our 0.1.0 release, but they can still keep track of which version worked for them. |
Great! As long as there is a fixed version we can test with I don't see an issue 👍 |
…chment element types
…on into careamics-ci-script
…bility and maintenance
…on into careamics-ci-script
CAREamics compatibility script, for automatic CI testing of CAREamics models in the BMZ.
Compatibility checks description
check_tool_compatibility
)v0.5
of thebioimageio.spec
, otherwise a failed report is returned.CAREamics
orcareamics
, if not returns anot-applicable
report.failed
report.load_from_bmz
function, if not returns afailed
report.failed
report.passed
report is returned.Notes
The existing uploaded CAREamics models should have their config renamed to
careamics.yaml
fromconfig.yml
, for these checks to pass.EDIT: Remove resolved questions and notes.