Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL validation + housekeeping #664

Merged
merged 17 commits into from
Dec 6, 2024
Merged

Fix URL validation + housekeeping #664

merged 17 commits into from
Dec 6, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Nov 25, 2024

set out to investigate #663 possibly caused by pydantic/pydantic#10925
but ended up avoid the issue by pinning pydantic in #671.

Let's wait for the next pydantic release to see if this needs further 'fixing' or if we just avoid some pydantic 2.10 releases...

So this PR just cleans up some code and fixes an issue with URL validation I encountered when adding more tests.

@github-actions github-actions bot added the bug Something isn't working label Nov 25, 2024
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch 3 times, most recently from 7ecc5b1 to bb4be9e Compare December 3, 2024 12:18
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch from bb4be9e to d9d4a75 Compare December 3, 2024 12:26
Copy link
Contributor

github-actions bot commented Dec 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4877 3769 77% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
bioimageio/spec/_internal/common_nodes.py 90% 🟢
bioimageio/spec/_internal/type_guards.py 84% 🟢
bioimageio/spec/_internal/url.py 95% 🟢
bioimageio/spec/_internal/validated_string.py 100% 🟢
bioimageio/spec/_internal/validation_context.py 96% 🟢
bioimageio/spec/_io.py 63% 🟢
bioimageio/spec/application/v0_3.py 100% 🟢
bioimageio/spec/common.py 100% 🟢
bioimageio/spec/dataset/v0_3.py 96% 🟢
bioimageio/spec/generic/v0_3.py 91% 🟢
bioimageio/spec/model/v0_5.py 68% 🟢
bioimageio/spec/notebook/v0_3.py 100% 🟢
TOTAL 90% 🟢

updated for commit: 44aa991 by action🐍

@github-actions github-actions bot added ci Continuous Integration github_actions Pull requests that update Github_actions code labels Dec 3, 2024
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch 3 times, most recently from c10567b to b497257 Compare December 4, 2024 08:27
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch 3 times, most recently from 0b14f52 to b41141f Compare December 4, 2024 10:41
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch from b41141f to 525b7d0 Compare December 4, 2024 10:41
@FynnBe FynnBe force-pushed the fix_for_pydantic_2.10 branch from 9744631 to 0f91b95 Compare December 4, 2024 13:20
@FynnBe FynnBe changed the title Fix for pydantic 2.10 Fix URL validation + housekeeping Dec 4, 2024
@FynnBe FynnBe marked this pull request as ready for review December 4, 2024 13:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 4, 2024
@FynnBe FynnBe merged commit 485deee into main Dec 6, 2024
9 checks passed
@FynnBe FynnBe deleted the fix_for_pydantic_2.10 branch December 6, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant