Fix Web UI Plugin Settings Files Not Handled Properly / Include PatientID in study view entries #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberio-baptista
changed the title
Enet4
reviewed
Nov 20, 2023
| @@ -102,7 +102,8 @@ const StudyView = createReactClass({ | |||
| uid: item.studyInstanceUID, | |||
| // deprecated data fields | |||
| "data-result-type": "study", | |||
| "data-result-uid": item.studyInstanceUID | |||
| "data-result-uid": item.studyInstanceUID, | |||
| "data-result-patientid": item.patientid | |||
There was a problem hiding this comment.
With this reasoning, maybe we should also provide more ID fields at the other levels?
Enet4
reviewed
Nov 30, 2023
dicoogle/src/main/resources/webapp/js/components/search/result/imageView.js
Outdated
Show resolved
Hide resolved
Enet4
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a broken feature of the web UI plugins' config files. Settings files are now properly loaded and provided to the respective web UI plugins.
Additionally, study entries in the UI will now have the associated Patient ID included, for additional context.
Description
Configurations for a web UI plugin have always been properly handled, so long as the files
(which must be named
[WebUIPluginName].json, seepackage.json'snameattribute) are stored inPlugins/settings. However, neither the Web UI servlet nordicoogle-webcore.jsdo any effort to provide or handle the settings so that web UI plugins can access these.This PR modifies the web UI servlet to include a new
settingsparameter, having the contents of the settings file, should it exist. Furthermore, the webcore was updated to include a newSettingsfield in registered plugins. This allows default webplugin classes to access this field by simply referring to their own attributes (i.e.:this.Settings) during therender(...)method.