[core] Add kill switch for dead plugin sets #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVM property `dicoogle.deadPluginKillSwitch`. If true, any dead plugin will kill the process
|
may be we can set as default behavior ? |
Can be done. I am just not sure how disruptive this change might be, since it could break an existing installation because of a plugin that we might not even care about. I say we test internally and draw our own conclusions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a safety measure against misconfigured or malfunctioning plugins. If the JVM property
dicoogle.deadPluginKillSwitchis set totrue(case insensitive), any dead plugin will kill the Dicoogle process, thus requiring devops to investigate and fix the issues reported in the logs.