Feature/lsm #24
Merged
Feature/lsm #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboulanger
requested review from
toloudis,
hughes036,
evamaxfield,
SeanLeRoy,
yrkim98 and
BrianWhitneyAI
evamaxfield
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Fine with me!
Meta note: tifffile can indeed read a lot more than these three, @toloudis @SeanLeRoy should we add the rest in another PR?
|
There might be extra work to do to make it work. Using the series in the reader is currently not loading properly multi position files for example. You could choose to have a reader per sub-type of tif file that uses tifffile but it would be quite a lot of work when tifffile exposes already properly the files as multi-dimensional array with properly annotated axes. What was the reasoning to handle the ome-tiff case separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #23
Description of Changes
Add LSM as a file supported by the tiffreader.