Go site 2246 gorule 0000001 rnac rna types are getting mangled #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting geneontology/go-site#2246 |
|
@mugitty Should I wait until the tests pass for review? |
Please wait until tests pass |
…ite-2246-gorule-0000001-rnac-rna-types-are-getting-mangled
|
@dustine32, I had to merge the updates from master Thanks |
|
@kltm and @dustine32 I have updated the CURIE lookup table with latest updates requested by @pgaudet and restored previous updates to tests. Please review |
dustine32
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
@mugitty Approved!
This matches what the issue geneontology/go-site#2246 asks for and the tests all pass. We can confirm this change's effects on a pipeline run.
|
Great! Can we now have a list of the entity types that fail ? (ideally by group - ie 'assigned by') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.