For #2360 - Updated to handle DBs without id syntax pattern #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking to geneontology/go-site#2360 |
dustine32
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@mugitty Ok, sorry this took so long for me to debug (thanks PyCharm!) and understand but I think this is good.
Basically, this now allows any prefix that's in dbxrefs.yaml to be a valid ID if it doesn't have any special ID syntax patterns. Whereas before, identity_matches_pattern would be False and attempting to iterate an empty dictionary of type_name_regex_patterns would be unable to set identity_matches_pattern to True, causing the ID to be considered invalid.
|
@dustine32, previously any db-xref's without id_syntax specifier were being flagged as being invalid. This update will permit db-xrefs without id_syntax specifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.